[jira] Commented: (FELIX-2741) NPE in ResolverImpl.calculatePackageSpaces

["Richard S. Hall (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974664#action_12974664 ] 

Richard S. Hall commented on FELIX-2741:
----------------------------------------

Well, I don't think doing a null check here will solve the issue, since m_wires should always be non-null for a resolved module. Even if there are no wires, it should be an empty list. Since the global lock is being held here to do the resolve, it doesn't seem like this would be a race condition with someone refreshing the bundle.

> NPE in ResolverImpl.calculatePackageSpaces
> ------------------------------------------
>
>                 Key: FELIX-2741
>                 URL: https://issues.apache.org/jira/browse/FELIX-2741
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: framework-3.0.6
>            Reporter: Sahoo
>             Fix For: framework-3.0.7
>
>
> A GlassFish user has reported a NPE while doing stress testing and the stack is given below:
> [#|2010-12-22T11:28:28.910+0100|INFO|glassfish3.1|javax.enterprise.system.std.com.sun.enterprise.server.logging|_ThreadID=18;_ThreadName=Thread-1;|java.lang.NullPointerException
>         at org.apache.felix.framework.resolver.ResolverImpl.calculatePackageSpaces(ResolverImpl.java:557)
>         at org.apache.felix.framework.resolver.ResolverImpl.calculatePackageSpaces(ResolverImpl.java:619)
>         at org.apache.felix.framework.resolver.ResolverImpl.calculatePackageSpaces(ResolverImpl.java:619)
>         at org.apache.felix.framework.resolver.ResolverImpl.resolve(ResolverImpl.java:94)
>         at org.apache.felix.framework.Felix$FelixResolver.resolve(Felix.java:3982)
>         at org.apache.felix.framework.Felix.resolveBundle(Felix.java:3397)
>         at org.apache.felix.framework.Felix.startBundle(Felix.java:1714)
>         at org.apache.felix.framework.BundleImpl.start(BundleImpl.java:922)
>         at org.apache.felix.fileinstall.internal.DirectoryWatcher.start(DirectoryWatcher.java:1136)
>         at org.apache.felix.fileinstall.internal.DirectoryWatcher.start(DirectoryWatcher.java:1122)
>         at org.apache.felix.fileinstall.internal.DirectoryWatcher.startAllBundles(DirectoryWatcher.java:1115)
>         at org.apache.felix.fileinstall.internal.DirectoryWatcher.process(DirectoryWatcher.java:433)
>         at org.apache.felix.fileinstall.internal.DirectoryWatcher.run(DirectoryWatcher.java:241)
>  |#]
> m_wires must be null for this NPE to be caused by the following code:
>             for (Wire wire : module.getWires())

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.