You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by bananer <gi...@git.apache.org> on 2018/03/07 16:55:39 UTC

[GitHub] thrift pull request #1500: THRIFT-4509: use nodejs 8.x from nodesource.com i...

GitHub user bananer opened a pull request:

    https://github.com/apache/thrift/pull/1500

    THRIFT-4509: use nodejs 8.x from nodesource.com in travis builds

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bananer/thrift THRIFT-4509-nodejs-version

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1500.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1500
    
----
commit f13c80f140ad8387a93c9549b94d39e59cfb53eb
Author: Philip Frank <ic...@...>
Date:   2018-03-07T16:54:24Z

    THRIFT-4509: use nodejs 8.x from nodesource.com in travis builds

----


---

[GitHub] thrift issue #1500: THRIFT-4509: use nodejs 8.x from nodesource.com in travi...

Posted by jeking3 <gi...@git.apache.org>.

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1500
  
    As of yesterday afternoon 4.x is no longer used.
    
    Due to the dependencies, and due to the fact that node.js 4.x LTS ends next month, I moved the "oldest" make check job to use nodejs 6.x (ubuntu-xenial) and the current one uses 8.x (ubuntu-artful) - this is the one that runs make check, make cross, ubsan, cppcheck, etc.
    
    We still need to modernize the code/test for js and nodejs however.


---

[GitHub] thrift pull request #1500: THRIFT-4509: use nodejs 8.x from nodesource.com i...

Posted by bananer <gi...@git.apache.org>.

Github user bananer closed the pull request at:

    https://github.com/apache/thrift/pull/1500


---

[GitHub] thrift issue #1500: THRIFT-4509: use nodejs 8.x from nodesource.com in travi...

Posted by bananer <gi...@git.apache.org>.

Github user bananer commented on the issue:

    https://github.com/apache/thrift/pull/1500
  
    @jeking3 where would the build encounter nodejs 4.2.6 then?


---