You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by "Jean-Louis Boudart (JIRA)" <ji...@apache.org> on 2011/04/04 17:23:05 UTC
[jira] [Created] (IVY-1281) Support dynamic revisions in
tag
Support dynamic revisions in <extends> tag
------------------------------------------
Key: IVY-1281
URL: https://issues.apache.org/jira/browse/IVY-1281
Project: Ivy
Issue Type: Improvement
Components: Core
Reporter: Jean-Louis Boudart
Current implementation of inheritance feature doesn't support dynamic revisions in <extends> tag.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (IVY-1281) Support dynamic revisions in
tag
Posted by "Jean-Louis Boudart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Louis Boudart updated IVY-1281:
------------------------------------
Attachment: IVY-1281+1287.patch
Please find the updated patch, i just run all tests, everything seems ok now.
Sorry for the successive test failures
> Support dynamic revisions in <extends> tag
> ------------------------------------------
>
> Key: IVY-1281
> URL: https://issues.apache.org/jira/browse/IVY-1281
> Project: Ivy
> Issue Type: Improvement
> Components: Core
> Reporter: Jean-Louis Boudart
> Attachments: IVY-1281+1287.patch
>
>
> Current implementation of inheritance feature doesn't support dynamic revisions in <extends> tag.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (IVY-1281) Support dynamic revisions in
tag
Posted by "Maarten Coene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019706#comment-13019706 ]
Maarten Coene commented on IVY-1281:
------------------------------------
I've tried to apply your patch, but the new unit test is failing:
{noformat}
apache#resolve-extends;1.0: java.lang.IllegalStateException: ivy file not found in cache for apache#resolve-extends;1.0: please resolve dependencies before delivering (C:\projects\ivy\ivy-dev\build\cache\resolved-apache-resolve-extends-1.0.xml)
at org.apache.ivy.ant.IvyDeliver.doExecute(IvyDeliver.java:426)
at org.apache.ivy.ant.IvyTask.execute(IvyTask.java:277)
at org.apache.ivy.ant.IvyPublish.doExecute(IvyPublish.java:308)
at org.apache.ivy.ant.IvyTask.execute(IvyTask.java:277)
at org.apache.ivy.ant.IvyPublishTest.testMergeParentWithoutPublishingParentForceDeliver(IvyPublishTest.java:218)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:324)
at junit.framework.TestCase.runTest(TestCase.java:164)
at junit.framework.TestCase.runBare(TestCase.java:130)
at junit.framework.TestResult$1.protect(TestResult.java:106)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.framework.TestResult.run(TestResult.java:109)
at junit.framework.TestCase.run(TestCase.java:120)
at junit.framework.TestSuite.runTest(TestSuite.java:230)
at junit.framework.TestSuite.run(TestSuite.java:225)
at org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:130)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)
Caused by: java.lang.IllegalStateException: ivy file not found in cache for apache#resolve-extends;1.0: please resolve dependencies before delivering (C:\projects\ivy\ivy-dev\build\cache\resolved-apache-resolve-extends-1.0.xml)
at org.apache.ivy.core.deliver.DeliverEngine.deliver(DeliverEngine.java:112)
at org.apache.ivy.Ivy.deliver(Ivy.java:597)
at org.apache.ivy.ant.IvyDeliver.doExecute(IvyDeliver.java:423)
... 22 more
--- Nested Exception ---
java.lang.IllegalStateException: ivy file not found in cache for apache#resolve-extends;1.0: please resolve dependencies before delivering (C:\projects\ivy\ivy-dev\build\cache\resolved-apache-resolve-extends-1.0.xml)
at org.apache.ivy.core.deliver.DeliverEngine.deliver(DeliverEngine.java:112)
at org.apache.ivy.Ivy.deliver(Ivy.java:597)
at org.apache.ivy.ant.IvyDeliver.doExecute(IvyDeliver.java:423)
at org.apache.ivy.ant.IvyTask.execute(IvyTask.java:277)
at org.apache.ivy.ant.IvyPublish.doExecute(IvyPublish.java:308)
at org.apache.ivy.ant.IvyTask.execute(IvyTask.java:277)
at org.apache.ivy.ant.IvyPublishTest.testMergeParentWithoutPublishingParentForceDeliver(IvyPublishTest.java:218)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:324)
at junit.framework.TestCase.runTest(TestCase.java:164)
at junit.framework.TestCase.runBare(TestCase.java:130)
at junit.framework.TestResult$1.protect(TestResult.java:106)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.framework.TestResult.run(TestResult.java:109)
at junit.framework.TestCase.run(TestCase.java:120)
at junit.framework.TestSuite.runTest(TestSuite.java:230)
at junit.framework.TestSuite.run(TestSuite.java:225)
at org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:130)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)
{noformat}
> Support dynamic revisions in <extends> tag
> ------------------------------------------
>
> Key: IVY-1281
> URL: https://issues.apache.org/jira/browse/IVY-1281
> Project: Ivy
> Issue Type: Improvement
> Components: Core
> Reporter: Jean-Louis Boudart
> Attachments: IVY-1281.patch
>
>
> Current implementation of inheritance feature doesn't support dynamic revisions in <extends> tag.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (IVY-1281) Support dynamic revisions in
tag
Posted by "Jean-Louis Boudart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Louis Boudart updated IVY-1281:
------------------------------------
Attachment: (was: IVY-1281.patch)
> Support dynamic revisions in <extends> tag
> ------------------------------------------
>
> Key: IVY-1281
> URL: https://issues.apache.org/jira/browse/IVY-1281
> Project: Ivy
> Issue Type: Improvement
> Components: Core
> Reporter: Jean-Louis Boudart
>
> Current implementation of inheritance feature doesn't support dynamic revisions in <extends> tag.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (IVY-1281) Support dynamic revisions in
tag
Posted by "Maarten Coene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maarten Coene resolved IVY-1281.
--------------------------------
Resolution: Fixed
Fix Version/s: trunk
Assignee: Maarten Coene
Patch has been applied in SVN trunk.
Many thanks!
> Support dynamic revisions in <extends> tag
> ------------------------------------------
>
> Key: IVY-1281
> URL: https://issues.apache.org/jira/browse/IVY-1281
> Project: Ivy
> Issue Type: Improvement
> Components: Core
> Reporter: Jean-Louis Boudart
> Assignee: Maarten Coene
> Fix For: trunk
>
> Attachments: IVY-1281+1287.patch
>
>
> Current implementation of inheritance feature doesn't support dynamic revisions in <extends> tag.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (IVY-1281) Support dynamic revisions in
tag
Posted by "Jean-Louis Boudart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Louis Boudart updated IVY-1281:
------------------------------------
Attachment: IVY-1281.patch
Here is a patch including a refactoring to support dynamic revisions in <extends> tag.
It also contains a new unit test.
> Support dynamic revisions in <extends> tag
> ------------------------------------------
>
> Key: IVY-1281
> URL: https://issues.apache.org/jira/browse/IVY-1281
> Project: Ivy
> Issue Type: Improvement
> Components: Core
> Reporter: Jean-Louis Boudart
> Attachments: IVY-1281.patch
>
>
> Current implementation of inheritance feature doesn't support dynamic revisions in <extends> tag.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (IVY-1281) Support dynamic revisions in
tag
Posted by "Maarten Coene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022916#comment-13022916 ]
Maarten Coene commented on IVY-1281:
------------------------------------
Thanks for the updated patch Jean-Louis.
Unfortunately another test is failing now:
{noformat}
junit.framework.ComparisonFailure: expected:<...module"
revision="[working@Vostro]"
status="integrat...> but was:<...module"
revision="[myrev]"
status="integrat...>
at junit.framework.Assert.assertEquals(Assert.java:81)
at junit.framework.Assert.assertEquals(Assert.java:87)
at org.apache.ivy.plugins.parser.xml.XmlModuleDescriptorWriterTest.testExtends(XmlModuleDescriptorWriterTest.java:125)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:324)
at junit.framework.TestCase.runTest(TestCase.java:164)
at junit.framework.TestCase.runBare(TestCase.java:130)
at junit.framework.TestResult$1.protect(TestResult.java:106)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.framework.TestResult.run(TestResult.java:109)
at junit.framework.TestCase.run(TestCase.java:120)
at junit.framework.TestSuite.runTest(TestSuite.java:230)
at junit.framework.TestSuite.run(TestSuite.java:225)
at org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:130)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)
{noformat}
> Support dynamic revisions in <extends> tag
> ------------------------------------------
>
> Key: IVY-1281
> URL: https://issues.apache.org/jira/browse/IVY-1281
> Project: Ivy
> Issue Type: Improvement
> Components: Core
> Reporter: Jean-Louis Boudart
> Attachments: IVY-1281+1287.patch, IVY-1281.patch
>
>
> Current implementation of inheritance feature doesn't support dynamic revisions in <extends> tag.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (IVY-1281) Support dynamic revisions in
tag
Posted by "Jean-Louis Boudart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Louis Boudart updated IVY-1281:
------------------------------------
Attachment: (was: IVY-1281.patch)
> Support dynamic revisions in <extends> tag
> ------------------------------------------
>
> Key: IVY-1281
> URL: https://issues.apache.org/jira/browse/IVY-1281
> Project: Ivy
> Issue Type: Improvement
> Components: Core
> Reporter: Jean-Louis Boudart
> Attachments: IVY-1281+1287.patch
>
>
> Current implementation of inheritance feature doesn't support dynamic revisions in <extends> tag.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (IVY-1281) Support dynamic revisions in
tag
Posted by "Jean-Louis Boudart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Louis Boudart updated IVY-1281:
------------------------------------
Attachment: IVY-1281+1287.patch
Added correction of IVY-1287 in the patch.
Using properties in extend tag's attributes was not supported.
Added support of a new extendType for licenses.
> Support dynamic revisions in <extends> tag
> ------------------------------------------
>
> Key: IVY-1281
> URL: https://issues.apache.org/jira/browse/IVY-1281
> Project: Ivy
> Issue Type: Improvement
> Components: Core
> Reporter: Jean-Louis Boudart
> Attachments: IVY-1281+1287.patch, IVY-1281.patch
>
>
> Current implementation of inheritance feature doesn't support dynamic revisions in <extends> tag.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (IVY-1281) Support dynamic revisions in
tag
Posted by "Jean-Louis Boudart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Louis Boudart updated IVY-1281:
------------------------------------
Attachment: IVY-1281.patch
My bad, when using forcedeliver we were corrupting the original module.ivy. It should be fixed in the new patch.
I also fixed a tiny bug when merging revision from parent. We checked for null value, but revision is never null.
When revision is null ivy set it with "working@[HOSTNAME".
> Support dynamic revisions in <extends> tag
> ------------------------------------------
>
> Key: IVY-1281
> URL: https://issues.apache.org/jira/browse/IVY-1281
> Project: Ivy
> Issue Type: Improvement
> Components: Core
> Reporter: Jean-Louis Boudart
> Attachments: IVY-1281.patch
>
>
> Current implementation of inheritance feature doesn't support dynamic revisions in <extends> tag.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (IVY-1281) Support dynamic revisions in
tag
Posted by "Jean-Louis Boudart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Louis Boudart updated IVY-1281:
------------------------------------
Attachment: (was: IVY-1281+1287.patch)
> Support dynamic revisions in <extends> tag
> ------------------------------------------
>
> Key: IVY-1281
> URL: https://issues.apache.org/jira/browse/IVY-1281
> Project: Ivy
> Issue Type: Improvement
> Components: Core
> Reporter: Jean-Louis Boudart
> Attachments: IVY-1281+1287.patch
>
>
> Current implementation of inheritance feature doesn't support dynamic revisions in <extends> tag.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira