[GitHub] [beam] emilymye commented on a change in pull request #13211: [BEAM-8106] Separate Java8/11 container image build tasks

[GitBox <gi...@apache.org>]

emilymye commented on a change in pull request #13211:
URL: https://github.com/apache/beam/pull/13211#discussion_r516283074



##########
File path: .test-infra/jenkins/job_PreCommit_Java_Examples_Dataflow_Java11.groovy
##########
@@ -46,7 +46,6 @@ builder.build {
     gradle {
       rootBuildScriptDir(properties.checkoutDir)
       tasks 'javaExamplesDataflowPreCommit'
-      switches '-PimageJavaVersion=11'

Review comment:
       since this uses the runner buildAndPushDockerContainer task which now checks for -PcompileAndRunTestsWithJava11, we don't need this flag anymore

##########
File path: sdks/java/container/build.gradle
##########
@@ -54,17 +55,6 @@ dependencies {
   dockerDependency library.java.kafka_clients
 }
 
-task copyDockerfileDependencies(type: Copy) {

Review comment:
       Docker tasks were split out into common.gradle




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org