You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Damodar Reddy Talakanti <da...@citrix.com> on 2014/03/25 12:33:45 UTC

Review Request 19604: [Windowsfication] fixing log issues on windows

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19604/
-----------------------------------------------------------

Review request for cloudstack and Abhinandan Prateek.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6105
    https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6105


Repository: cloudstack-git


Description
-------

After Windowsfication logs were not getting generated properly on windows. Fixed the same by updating tomcat's properties in MSI installer


Diffs
-----

  scripts/installer/windows/acs.wxs 7967478 

Diff: https://reviews.apache.org/r/19604/diff/


Testing
-------

As changes are related to windows tested whether log files are getting generated or not in windows.


Thanks,

Damodar Reddy Talakanti

Re: Review Request 19604: [Windowsfication] fixing log issues on windows

Posted by Damodar Reddy Talakanti <da...@citrix.com>.

> On March 26, 2014, 5:59 a.m., Rajani Karuturi wrote:
> > scripts/installer/windows/acs.wxs, line 202
> > <https://reviews.apache.org/r/19604/diff/1/?file=535170#file535170line202>
> >
> >     a mix of '//' and '\' is used. If possible, use one

//US/Tomcat6 is not the file path.It is the type of argument expected by tomcat6.exe to update the service parameters.


- Damodar Reddy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19604/#review38578
-----------------------------------------------------------


On March 25, 2014, 11:33 a.m., Damodar Reddy Talakanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19604/
> -----------------------------------------------------------
> 
> (Updated March 25, 2014, 11:33 a.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6105
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6105
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> After Windowsfication logs were not getting generated properly on windows. Fixed the same by updating tomcat's properties in MSI installer
> 
> 
> Diffs
> -----
> 
>   scripts/installer/windows/acs.wxs 7967478 
> 
> Diff: https://reviews.apache.org/r/19604/diff/
> 
> 
> Testing
> -------
> 
> As changes are related to windows tested whether log files are getting generated or not in windows.
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>

Re: Review Request 19604: [Windowsfication] fixing log issues on windows

Posted by Rajani Karuturi <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19604/#review38578
-----------------------------------------------------------



scripts/installer/windows/acs.wxs
<https://reviews.apache.org/r/19604/#comment70850>

    a mix of '//' and '\' is used. If possible, use one


- Rajani Karuturi


On March 25, 2014, 11:33 a.m., Damodar Reddy Talakanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19604/
> -----------------------------------------------------------
> 
> (Updated March 25, 2014, 11:33 a.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6105
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6105
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> After Windowsfication logs were not getting generated properly on windows. Fixed the same by updating tomcat's properties in MSI installer
> 
> 
> Diffs
> -----
> 
>   scripts/installer/windows/acs.wxs 7967478 
> 
> Diff: https://reviews.apache.org/r/19604/diff/
> 
> 
> Testing
> -------
> 
> As changes are related to windows tested whether log files are getting generated or not in windows.
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>