You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by Marc Portier <mp...@outerthought.org> on 2002/07/25 10:50:07 UTC

templates.build.xml

Hi all,

1 [WIP]
working on the templates.build.xml to complete the remote building steps...

I'm getting more and more the feeling that this could be a nice opportunity
to maybe also rehaul the build.xml and make it a bit more readable (using
the upcoming templates)

any comments welcome.


2 [removing some <filter>]
Maybe a first question from my side:
on the <filter> stuff:

I read the comment on the inputmodules for the sitemap, so I guess this will
eventually go
but in the mean time I guess its needed to make it work

just one question: there is currently filtering on the xml-content of the
./src/documentation/**/*.x* files, is that really necessary?

(fun coincidence: the primer document
(http://www.krysalis.org/forrest/primer.html) fails to correctly show the
skinit pipeline fragment because of this...@skin@ is translated to bert
:-) )

I will do some more searches and hope come to this conclusion:
- nobody (except, Steven's primer.xml which is not knowing, and in the wrong
way) is using the @skin@, @link#@, ... inside the actual documents (only the
xsl's)
- it's not a way of working we 'ld like to advocate
so before someone thinks he wants to use it because it happens to work
ATM...

I'll make a list of who and what is using the @token@ s in a new mail.  If
we can all agree on what and why I hope we can conclude to removing filter
translations on the xml content in src/documentation/**


3 [warning: current side effect]
one thing more: because of this approach the choice of skin is in fact
active in the prepare stage rather then in the generate stage (there will be
a small change to the forrestbot.conf.xml to reflect that)


regards,

-marc=
--
Marc Portier                            http://outerthought.org/
Outerthought - Open Source, Java & XML Competence Support Center
mpo@outerthought.org                      info@outerthought.org


RE: templates.build.xml

Posted by Marc Portier <mp...@outerthought.org>.
> -----Original Message-----
> From: Nicola Ken Barozzi [mailto:nicolaken@apache.org]
> Marc Portier wrote:
> > Hi all,
> > 
> > 1 [WIP]
> > working on the templates.build.xml to complete the remote 
> building steps...
> > 
> > I'm getting more and more the feeling that this could be a nice 
> opportunity
> > to maybe also rehaul the build.xml and make it a bit more 
> readable (using
> > the upcoming templates)
> > 
> > any comments welcome.
> 
> We should do our site as we do the others, I agree.
> 

yep, that was the idea.... use the templates from inside build.xml

-marc=

Re: templates.build.xml

Posted by Nicola Ken Barozzi <ni...@apache.org>.
Marc Portier wrote:
> Hi all,
> 
> 1 [WIP]
> working on the templates.build.xml to complete the remote building steps...
> 
> I'm getting more and more the feeling that this could be a nice opportunity
> to maybe also rehaul the build.xml and make it a bit more readable (using
> the upcoming templates)
> 
> any comments welcome.

We should do our site as we do the others, I agree.

> 2 [removing some <filter>]
> Maybe a first question from my side:
> on the <filter> stuff:
> 
> I read the comment on the inputmodules for the sitemap, so I guess this will
> eventually go
> but in the mean time I guess its needed to make it work
> 
> just one question: there is currently filtering on the xml-content of the
> ./src/documentation/**/*.x* files, is that really necessary?

No.

> (fun coincidence: the primer document
> (http://www.krysalis.org/forrest/primer.html) fails to correctly show the
> skinit pipeline fragment because of this...@skin@ is translated to bert
> :-) )
> 
> I will do some more searches and hope come to this conclusion:
> - nobody (except, Steven's primer.xml which is not knowing, and in the wrong
> way) is using the @skin@, @link#@, ... inside the actual documents (only the
> xsl's)
> - it's not a way of working we 'ld like to advocate
> so before someone thinks he wants to use it because it happens to work
> ATM...
> 
> I'll make a list of who and what is using the @token@ s in a new mail.  If
> we can all agree on what and why I hope we can conclude to removing filter
> translations on the xml content in src/documentation/**

+1 to remove it right away.
Nobody uses it IIRC.

> 3 [warning: current side effect]
> one thing more: because of this approach the choice of skin is in fact
> active in the prepare stage rather then in the generate stage (there will be
> a small change to the forrestbot.conf.xml to reflect that)

np

-- 
Nicola Ken Barozzi                   nicolaken@apache.org
             - verba volant, scripta manent -
    (discussions get forgotten, just code remains)
---------------------------------------------------------------------


Re: templates.build.xml

Posted by "J.Pietschmann" <j3...@yahoo.de>.
Steven Noels wrote:
> there is some filtering applied on the book.xml in 
> src/documentation/content/xdocs:

Which is a *bad* idea.

> <?xml version="1.0" encoding="UTF-8"?>
> <!DOCTYPE book PUBLIC "-//APACHE//DTD Cocoon Documentation Book 
> V1.0//EN" "book-cocoon-v10.dtd">
> <book software="Forrest" title="Apache Forrest" copyright="@year@ The 
> Apache Foundation" xmlns:xlink="http://www.w3.org/1999/xlink">

Ironically, the @copyright attributes in book.xml (and other
files) are never used.

Thou shalt not do simple string replacements on *any* XML
file (including XSL files). Use aggregation+XSLT.

J.Pietschmann



RE: templates.build.xml

Posted by Marc Portier <mp...@outerthought.org>.
> > 
> > there is some filtering applied on the book.xml in 
> > src/documentation/content/xdocs:
> > 
> > <?xml version="1.0" encoding="UTF-8"?>
> > <!DOCTYPE book PUBLIC "-//APACHE//DTD Cocoon Documentation Book 
> > V1.0//EN" "book-cocoon-v10.dtd">
> > <book software="Forrest" title="Apache Forrest" copyright="@year@ The 
> > Apache Foundation" xmlns:xlink="http://www.w3.org/1999/xlink">
> 
> I'd say hardcode them.
> 
as with the others... see my other posting
while you guys were solving everything I was still trying to understand :-)

-marc=

Re: templates.build.xml

Posted by Nicola Ken Barozzi <ni...@apache.org>.
Steven Noels wrote:
> Marc Portier wrote:
> 
>> 2 [removing some <filter>]
>> Maybe a first question from my side:
>> on the <filter> stuff:
>>
>> I read the comment on the inputmodules for the sitemap, so I guess 
>> this will
>> eventually go
>> but in the mean time I guess its needed to make it work
>>
>> just one question: there is currently filtering on the xml-content of the
>> ./src/documentation/**/*.x* files, is that really necessary?
> 
> 
> there is some filtering applied on the book.xml in 
> src/documentation/content/xdocs:
> 
> <?xml version="1.0" encoding="UTF-8"?>
> <!DOCTYPE book PUBLIC "-//APACHE//DTD Cocoon Documentation Book 
> V1.0//EN" "book-cocoon-v10.dtd">
> <book software="Forrest" title="Apache Forrest" copyright="@year@ The 
> Apache Foundation" xmlns:xlink="http://www.w3.org/1999/xlink">

I'd say hardcode them.

-- 
Nicola Ken Barozzi                   nicolaken@apache.org
             - verba volant, scripta manent -
    (discussions get forgotten, just code remains)
---------------------------------------------------------------------


Re: templates.build.xml

Posted by Steven Noels <st...@outerthought.org>.
Marc Portier wrote:

> 2 [removing some <filter>]
> Maybe a first question from my side:
> on the <filter> stuff:
> 
> I read the comment on the inputmodules for the sitemap, so I guess this will
> eventually go
> but in the mean time I guess its needed to make it work
> 
> just one question: there is currently filtering on the xml-content of the
> ./src/documentation/**/*.x* files, is that really necessary?

there is some filtering applied on the book.xml in 
src/documentation/content/xdocs:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE book PUBLIC "-//APACHE//DTD Cocoon Documentation Book 
V1.0//EN" "book-cocoon-v10.dtd">
<book software="Forrest" title="Apache Forrest" copyright="@year@ The 
Apache Foundation" xmlns:xlink="http://www.w3.org/1999/xlink">

</Steven>
-- 
Steven Noels                            http://outerthought.org/
Outerthought - Open Source, Java & XML Competence Support Center
stevenn@outerthought.org                      stevenn@apache.org