You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/03/10 00:30:08 UTC
[GitHub] [bookkeeper] nicoloboschi commented on a change in pull request #2944: Fix wrong ledger id parse radix for index relocation file in IndexPersistenceMgr
nicoloboschi commented on a change in pull request #2944:
URL: https://github.com/apache/bookkeeper/pull/2944#discussion_r770438189
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfo.java
##########
@@ -549,6 +549,7 @@ public synchronized void moveToNewLocation(File newFile, long size) throws IOExc
}
fc = new RandomAccessFile(newFile, mode).getChannel();
lf = newFile;
+ deleted = false;
Review comment:
yes, the correct behavior would be to call `lf.delete()` directly because the `FileInfo` is an abstraction and `moveToNewLocation` is not expected the be in `deleted` state at all during the rename.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org