You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "srielau (via GitHub)" <gi...@apache.org> on 2026/07/16 14:01:17 UTC
[PR] [SPARK-58125][SQL] SQL ASOF JOIN integration tests [spark]
srielau opened a new pull request, #57304:
URL: https://github.com/apache/spark/pull/57304
## What changes were proposed in this pull request?
Consolidates the SQL ASOF JOIN Scala integration test suites for subtask 4 of [SPARK-58092](https://issues.apache.org/jira/browse/SPARK-58092):
- **`AsOfJoinSQLSuite`** — parser and analysis negative paths (unchanged in this PR; lives on earlier stack frames).
- **`AsOfJoinSortMergeSQLSuite`** — execution semantics with sort-merge enabled:
- Remove duplicate analysis-negative tests already covered by `AsOfJoinSQLSuite`.
- Add non-equi `ON` clause execution tests derived from FVT semantics fixtures (range filter on right, `abs(unix_timestamp(...))` tolerance-style predicate, disjunction, cross-table expressions, `ON TRUE` / `ON FALSE`).
FVT golden-file tests (`join-asof-*.sql` via `SQLQueryTestSuite`) remain a separate follow-up PR on branch `SPARK-58093-ASOF-JOIN-FVT`.
Stack order: #57251 (merged) → #57264 → #57277 → this PR.
### Why are the changes needed?
Separates integration-test ownership for the stacked PR series and closes coverage gaps for general `ON boolean_expression` behavior under sort-merge execution.
### Does this PR introduce any user-facing change?
No — test-only change.
## How was this patch tested?
Locally in worktree `spark-SPARK-58125`:
```bash
./dev/lint-scala
build/sbt -Dscalastyle.skip=true \
"sql/testOnly org.apache.spark.sql.AsOfJoinSQLSuite \
org.apache.spark.sql.AsOfJoinSortMergeSQLSuite"
```
Results: scalastyle clean; **38/38** tests passed (7 + 31).
## Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58125][SQL] SQL ASOF JOIN integration tests [spark]
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on PR #57304:
URL: https://github.com/apache/spark/pull/57304#issuecomment-4995610633
Collapsed into SPARK-58124 (#57277): integration tests are additive test-only changes in the same AsOfJoinSortMergeSQLSuite file already owned by the execution PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58125][SQL] SQL ASOF JOIN integration tests [spark]
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau closed pull request #57304: [SPARK-58125][SQL] SQL ASOF JOIN integration tests
URL: https://github.com/apache/spark/pull/57304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org