You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/05/08 03:32:25 UTC

Review Request 21190: Added intersection test for stout Interval and IntervalSet.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21190/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Vinod Kone.


Repository: mesos-git


Description
-------

See summary. THis patch is needed in network isolator.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp c84e0c6 
  3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp ecca829 

Diff: https://reviews.apache.org/r/21190/diff/


Testing
-------

make check.


Thanks,

Jie Yu


Re: Review Request 21190: Added intersection test for stout Interval and IntervalSet.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21190/#review42457
-----------------------------------------------------------


Patch looks great!

Reviews applied: [21190]

All tests passed.

- Mesos ReviewBot


On May 8, 2014, 1:32 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21190/
> -----------------------------------------------------------
> 
> (Updated May 8, 2014, 1:32 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary. THis patch is needed in network isolator.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp c84e0c6 
>   3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp ecca829 
> 
> Diff: https://reviews.apache.org/r/21190/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Re: Review Request 21190: Added intersection test for stout Interval and IntervalSet.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21190/#review42527
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On May 8, 2014, 1:32 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21190/
> -----------------------------------------------------------
> 
> (Updated May 8, 2014, 1:32 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary. THis patch is needed in network isolator.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp c84e0c6 
>   3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp ecca829 
> 
> Diff: https://reviews.apache.org/r/21190/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>