[GitHub] [doris] SWJTU-ZhangLei commented on a diff in pull request #10429: [Bugfix](fe) fix add follower failed, conflict socket .

[GitBox <gi...@apache.org>]

SWJTU-ZhangLei commented on code in PR #10429:
URL: https://github.com/apache/doris/pull/10429#discussion_r908121349


##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Catalog.java:
##########
@@ -2463,10 +2463,12 @@ public void addFrontend(FrontendNodeType role, String host, int editLogPort) thr
 
             fe = new Frontend(role, nodeName, host, editLogPort);
             frontends.put(nodeName, fe);
+            BDBHA bdbha = (BDBHA) haProtocol;
             if (role == FrontendNodeType.FOLLOWER || role == FrontendNodeType.REPLICA) {
-                ((BDBHA) getHaProtocol()).addHelperSocket(host, editLogPort);
+                bdbha.addHelperSocket(host, editLogPort);

Review Comment:
   > Where does the conflict occur, and should we `removeConflictNodeIfExist` and then `addHelperSocket`?
   
   help socket is used for self to connect with.  firstly add help socket, secondly we can communicate with cluster.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org