[I] [Feature] Support module definition change in BanyanDB storage. [skywalking]

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng opened a new issue, #12685:
URL: https://github.com/apache/skywalking/issues/12685

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   Currently, we don't do column validation(name, type, existing) during booting, and would not upgrade the column update when the latest and existing are compatible. 
   
   We should consider adding this. Elasticsearch storage implementation would be a good reference.
   
   ### Use case
   
   _No response_
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a pull request to implement this on your own?
   
   - [ ] Yes I am willing to submit a pull request on my own!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Feature] Support module definition change in BanyanDB storage. [skywalking]

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng closed issue #12685: [Feature] Support module definition change in BanyanDB storage.
URL: https://github.com/apache/skywalking/issues/12685


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Feature] Support module definition change in BanyanDB storage. [skywalking]

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng commented on issue #12685:
URL: https://github.com/apache/skywalking/issues/12685#issuecomment-2496016033

   > @wankai123 Considering #12442, let's add a database version number concept in OAP codebase. Once we have this in place, we have a chance to do incompatible upgrade through two group.
   > 
   > e.g. banyandb_db_schema_v = 1, and we need some incompatible upgrade, introduced a new kind of index, but the query logic is consistent. We could do banyandb_db_schema_v=2(compatible with banyandb_db_schema_v=1).
   > 
   > Then, when we apply definition change through create new schema_v suffix groups.
   
   @wankai123 #12442 has been moved to 0.9, so OAP will consider that for 10.3 only.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Feature] Support module definition change in BanyanDB storage. [skywalking]

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng commented on issue #12685:
URL: https://github.com/apache/skywalking/issues/12685#issuecomment-2495761290

   @wankai123 Considering https://github.com/apache/skywalking/issues/12442, let's add a database version number concept in OAP codebase. Once we have this in place, we have a chance to do incompatible upgrade through two group.
   
   e.g. banyandb_db_schema_v = 1, and we need some incompatible upgrade, introduced a new kind of index, but the query logic is consistent. We could do banyandb_db_schema_v=2(compatible with banyandb_db_schema_v=1).
   
   Then, when we apply definition change through create new schema_v suffix groups.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org