You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/09 18:55:27 UTC
[GitHub] [kafka] hachikuji commented on a change in pull request #10021: KAFKA-12205: Delete snapshots less than the snapshot at the log start
hachikuji commented on a change in pull request #10021:
URL: https://github.com/apache/kafka/pull/10021#discussion_r590634783
##########
File path: raft/src/test/java/org/apache/kafka/snapshot/SnapshotsTest.java
##########
@@ -74,5 +79,44 @@ public void testInvalidSnapshotFilenames() {
assertEquals(Optional.empty(), Snapshots.parse(root.resolve("leader-epoch-checkpoint")));
// partition metadata
assertEquals(Optional.empty(), Snapshots.parse(root.resolve("partition.metadata")));
+ // deleted file
+ assertEquals(Optional.empty(), Snapshots.parse(root.resolve("00000000000000000000.deleted")));
+ }
+
+ @Test
+ public void testDeleteSnapshot() throws IOException {
+
+ OffsetAndEpoch snapshotId = new OffsetAndEpoch(
+ TestUtils.RANDOM.nextInt(Integer.MAX_VALUE),
+ TestUtils.RANDOM.nextInt(Integer.MAX_VALUE)
+ );
+
+ Path logDirPath = TestUtils.tempDirectory().toPath();
+ try (FileRawSnapshotWriter snapshot = FileRawSnapshotWriter.create(logDirPath, snapshotId, Optional.empty())) {
+ snapshot.freeze();
+
+ Path snapshotPath = Snapshots.snapshotPath(logDirPath, snapshotId);
+ assertTrue(Files.exists(snapshotPath));
+
+ // delete snapshot directly
+ assertTrue(Snapshots.deleteSnapshotIfExists(logDirPath, snapshot.snapshotId()));
+ assertFalse(Files.exists(snapshotPath));
+ assertFalse(Files.exists(Snapshots.deleteRename(snapshotPath, snapshotId)));
+ }
+
+ try (FileRawSnapshotWriter snapshot = FileRawSnapshotWriter.create(logDirPath, snapshotId, Optional.empty())) {
+ snapshot.freeze();
+
+ Path snapshotPath = Snapshots.snapshotPath(logDirPath, snapshotId);
+ assertTrue(Files.exists(snapshotPath));
+
+ // rename snapshot before deleting
+ Utils.atomicMoveWithFallback(snapshotPath, Snapshots.deleteRename(snapshotPath, snapshotId));
Review comment:
nit: I think this is the only difference between this block and the previous. Can we factor out a helper?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org