[jira] [Updated] (HDFS-11476) Fix NPE in FsDatasetImpl#checkAndUpdate

["Xiaobing Zhou (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HDFS-11476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Xiaobing Zhou updated HDFS-11476:
---------------------------------
    Attachment: HDFS-11476.000.patch

Posted v0 patch for reviews.

> Fix NPE in FsDatasetImpl#checkAndUpdate
> ---------------------------------------
>
>                 Key: HDFS-11476
>                 URL: https://issues.apache.org/jira/browse/HDFS-11476
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Xiaobing Zhou
>            Assignee: Xiaobing Zhou
>         Attachments: HDFS-11476.000.patch
>
>
> diskMetaFile can be null and passed to compareTo which dereferences it, causing NPE
> {code}
> // Compare generation stamp
>       if (memBlockInfo.getGenerationStamp() != diskGS) {
>         File memMetaFile = FsDatasetUtil.getMetaFile(diskFile, 
>             memBlockInfo.getGenerationStamp());
>         if (memMetaFile.exists()) {
>           if (memMetaFile.compareTo(diskMetaFile) != 0) {
>             LOG.warn("Metadata file in memory "
>                 + memMetaFile.getAbsolutePath()
>                 + " does not match file found by scan "
>                 + (diskMetaFile == null? null: diskMetaFile.getAbsolutePath()));
>           }
>         } else {
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org