You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@juddi.apache.org by tc...@apache.org on 2010/01/24 19:33:25 UTC
svn commit: r902617 - in /webservices/juddi/trunk:
juddi-core/src/main/java/org/apache/juddi/api/impl/
juddi-core/src/main/java/org/apache/juddi/subscription/
juddiv3-war/src/main/java/org/apache/juddi/servlets/
Author: tcunning
Date: Sun Jan 24 18:33:25 2010
New Revision: 902617
URL: http://svn.apache.org/viewvc?rev=902617&view=rev
Log:
JUDDI-328
Change NotificationList's Vector to a commons-collection synchronized
bounded buffer.
Modified:
webservices/juddi/trunk/juddi-core/src/main/java/org/apache/juddi/api/impl/JUDDIApiImpl.java
webservices/juddi/trunk/juddi-core/src/main/java/org/apache/juddi/api/impl/UDDISubscriptionListenerImpl.java
webservices/juddi/trunk/juddi-core/src/main/java/org/apache/juddi/subscription/NotificationList.java
webservices/juddi/trunk/juddiv3-war/src/main/java/org/apache/juddi/servlets/NotifyServlet.java
Modified: webservices/juddi/trunk/juddi-core/src/main/java/org/apache/juddi/api/impl/JUDDIApiImpl.java
URL: http://svn.apache.org/viewvc/webservices/juddi/trunk/juddi-core/src/main/java/org/apache/juddi/api/impl/JUDDIApiImpl.java?rev=902617&r1=902616&r2=902617&view=diff
==============================================================================
--- webservices/juddi/trunk/juddi-core/src/main/java/org/apache/juddi/api/impl/JUDDIApiImpl.java (original)
+++ webservices/juddi/trunk/juddi-core/src/main/java/org/apache/juddi/api/impl/JUDDIApiImpl.java Sun Jan 24 18:33:25 2010
@@ -70,6 +70,7 @@
import org.uddi.sub_v3.SubscriptionResultsList;
import org.uddi.v3_service.DispositionReportFaultMessage;
import org.uddi.v3_service.UDDISubscriptionPortType;
+import org.apache.commons.collections.Buffer;
/**
* @author <a href="mailto:jfaath@apache.org">Jeff Faath</a>
@@ -559,14 +560,7 @@
log.info("Notification received by UDDISubscriptionListenerService : " + sw.toString());
NotificationList nl = NotificationList.getInstance();
- if (nl.getNotifications().size() == MAX_NOTIFICATIONS) {
- nl.getNotifications().setSize(MAX_NOTIFICATIONS - 1);
- }
- nl.getNotifications().add(0, sw.toString());
-// Vector vect = nl.getNotifications();
-// for (int i = 0; i < vect.size(); i++) {
-// String str = (String) vect.get(i);
-// }
+ nl.getNotifications().add(sw.toString());
//update the registry with the notification list.
XRegisterHelper.handle(fromClerk, toClerk, list);
Modified: webservices/juddi/trunk/juddi-core/src/main/java/org/apache/juddi/api/impl/UDDISubscriptionListenerImpl.java
URL: http://svn.apache.org/viewvc/webservices/juddi/trunk/juddi-core/src/main/java/org/apache/juddi/api/impl/UDDISubscriptionListenerImpl.java?rev=902617&r1=902616&r2=902617&view=diff
==============================================================================
--- webservices/juddi/trunk/juddi-core/src/main/java/org/apache/juddi/api/impl/UDDISubscriptionListenerImpl.java (original)
+++ webservices/juddi/trunk/juddi-core/src/main/java/org/apache/juddi/api/impl/UDDISubscriptionListenerImpl.java Sun Jan 24 18:33:25 2010
@@ -26,6 +26,7 @@
import javax.xml.bind.JAXBException;
import javax.xml.bind.Marshaller;
+import org.apache.commons.collections.Buffer;
import org.apache.juddi.config.PersistenceManager;
import org.apache.juddi.mapping.MappingModelToApi;
import org.apache.juddi.subscription.NotificationList;
Modified: webservices/juddi/trunk/juddi-core/src/main/java/org/apache/juddi/subscription/NotificationList.java
URL: http://svn.apache.org/viewvc/webservices/juddi/trunk/juddi-core/src/main/java/org/apache/juddi/subscription/NotificationList.java?rev=902617&r1=902616&r2=902617&view=diff
==============================================================================
--- webservices/juddi/trunk/juddi-core/src/main/java/org/apache/juddi/subscription/NotificationList.java (original)
+++ webservices/juddi/trunk/juddi-core/src/main/java/org/apache/juddi/subscription/NotificationList.java Sun Jan 24 18:33:25 2010
@@ -1,24 +1,25 @@
package org.apache.juddi.subscription;
-import java.util.Vector;
+import org.apache.commons.collections.buffer.CircularFifoBuffer;
+import org.apache.commons.collections.Buffer;
+import org.apache.commons.collections.BufferUtils;
-public class NotificationList {
+public class NotificationList {
private static NotificationList nl = null;
- private static Vector<String> list = null;
+ private static Buffer list = null;
private NotificationList() {
- list = new Vector<String>();
+ list = BufferUtils.synchronizedBuffer(new CircularFifoBuffer(10));
}
public static NotificationList getInstance() {
if (nl == null) {
nl = new NotificationList();
}
- return nl;
+ return nl;
}
- public Vector<String> getNotifications() {
+ public Buffer getNotifications() {
return list;
}
-
}
Modified: webservices/juddi/trunk/juddiv3-war/src/main/java/org/apache/juddi/servlets/NotifyServlet.java
URL: http://svn.apache.org/viewvc/webservices/juddi/trunk/juddiv3-war/src/main/java/org/apache/juddi/servlets/NotifyServlet.java?rev=902617&r1=902616&r2=902617&view=diff
==============================================================================
--- webservices/juddi/trunk/juddiv3-war/src/main/java/org/apache/juddi/servlets/NotifyServlet.java (original)
+++ webservices/juddi/trunk/juddiv3-war/src/main/java/org/apache/juddi/servlets/NotifyServlet.java Sun Jan 24 18:33:25 2010
@@ -17,6 +17,7 @@
import java.io.IOException;
import java.io.PrintWriter;
+import java.util.Iterator;
import java.util.Vector;
import javax.servlet.ServletException;
@@ -24,6 +25,7 @@
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
+import org.apache.commons.collections.Buffer;
import org.apache.juddi.subscription.NotificationList;
@@ -43,11 +45,11 @@
ServletException, IOException {
StringBuffer sb = new StringBuffer();
- Vector nl = NotificationList.getInstance().getNotifications();
- if (nl.size() != 0) {
- for (int i = 0; i<nl.size(); i++) {
- sb.append(nl.get(i));
- }
+ Buffer nl = NotificationList.getInstance().getNotifications();
+ Iterator it = nl.iterator();
+ while (it.hasNext()) {
+ String notification = (String) it.next();
+ sb.append(notification);
}
nl.clear();
PrintWriter out = response.getWriter();
---------------------------------------------------------------------
To unsubscribe, e-mail: juddi-cvs-unsubscribe@ws.apache.org
For additional commands, e-mail: juddi-cvs-help@ws.apache.org