[GitHub] jon-wei commented on issue #6828: Kill Hadoop MR task on kill of Hadoop ingestion task

[GitBox <gi...@apache.org>]

jon-wei commented on issue #6828: Kill Hadoop MR task on kill of Hadoop ingestion task 
URL: https://github.com/apache/incubator-druid/pull/6828#issuecomment-455374160
 
 
   @ankit0811 
   
   I would change AbstractTask so that stopGracefully() no longer throws an exception but just does nothing:
   
   ``` @Override
     public void stopGracefully()
     {
       // Should not be called when canRestore = false.
       throw new UnsupportedOperationException("Cannot stop gracefully");
     }
   ```
   
   For the tasks that did have a stopGracefully() implementation (AppenderatorDriverRealtimeIndexTask, RealtimeIndexTask, SeekableStreamIndexTask), this used to  be called only when `taskConfig. isRestoreOnRestart` is true, so that check should be moved now into the stopGracefully() implementations there.
   
   You could change the stopGracefully() method to have the task runner pass in the TaskConfig object for access to `restoreTasksOnRestart`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org