[GitHub] kristw commented on a change in pull request #5815: Improve categorical color management

[GitBox <gi...@apache.org>]

kristw commented on a change in pull request #5815: Improve categorical color management
URL: https://github.com/apache/incubator-superset/pull/5815#discussion_r216855316
 
 

 ##########
 File path: superset/assets/src/modules/CategoricalColorScale.js
 ##########
 @@ -0,0 +1,58 @@
+import { TIME_SHIFT_PATTERN } from '../utils/common';
+
+export function cleanValue(value) {
 
 Review comment:
   I agree it should not be here at all but have to track down which component really need this cleaning. can be tricky 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org