[GitHub] [orc] coderex2522 commented on a change in pull request #1062: ORC-1125: [C++] Support reading decimal64 in ORCv2

[GitBox <gi...@apache.org>]

coderex2522 commented on a change in pull request #1062:
URL: https://github.com/apache/orc/pull/1062#discussion_r825576830



##########
File path: c++/src/Reader.cc
##########
@@ -1389,6 +1389,13 @@ namespace orc {
       contents->footer = REDUNDANT_MOVE(readFooter(stream.get(), buffer.get(),
         footerOffset, *contents->postscript,  *contents->pool));
     }
+    if (contents->postscript->version_size() != 2) {
+      contents->fileVersion = std::unique_ptr<FileVersion>(new FileVersion(0, 11));

Review comment:
       Can this statement 'new FileVersion(0,11)' be changed to 'new FileVersion(FileVersion::v_0_11())'.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org