You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@royale.apache.org by GitBox <gi...@apache.org> on 2020/09/04 05:41:47 UTC

[GitHub] [royale-asjs] tranquiliste opened a new issue #903: no automatic resizing after addChild (mx)

tranquiliste opened a new issue #903:
URL: https://github.com/apache/royale-asjs/issues/903


   Hello,
   
   Following Yishay advice, I create this issue about DOM note automatically resising after adding a child.
   I have created a test project wich  displays a button to add 4 labels to the dom
   By default labels are added but parent DOM size is not modified, so you can view the labels only by scrolling
   If you uncomment the line 33 of the Ecran2Class ( fire "layoutNeeded" event) you get the behaviour I would like to have.
   
   I use 0.9.7 to compile
   
   Thanks for your help
   
   Nicolas
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] tranquiliste commented on issue #903: no automatic resizing after addChild (mx)

Posted by GitBox <gi...@apache.org>.
tranquiliste commented on issue #903:
URL: https://github.com/apache/royale-asjs/issues/903#issuecomment-686923182


   [testDynamicLayout.zip](https://github.com/apache/royale-asjs/files/5172905/testDynamicLayout.zip)
   with the test project attached


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] tranquiliste commented on issue #903: no automatic resizing after addChild (mx)

Posted by GitBox <gi...@apache.org>.
tranquiliste commented on issue #903:
URL: https://github.com/apache/royale-asjs/issues/903#issuecomment-688073693


   Hello,
   
   I tried to look at the issue, but could not find  what's wrong. Height of DOM inside which we added the four labels is correctly calculated but not its parent.
   Is it a matter of adding a bead? if so I could not find which one.
   
   Any help would be apreciated.
   Thanks
   Nicolas


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] aharui commented on issue #903: no automatic resizing after addChild (mx)

Posted by GitBox <gi...@apache.org>.
aharui commented on issue #903:
URL: https://github.com/apache/royale-asjs/issues/903#issuecomment-695015292


   I went and fixed that in this commit: b01a9aa83ea876a386695f78d043aca9ae749604


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] tranquiliste commented on issue #903: no automatic resizing after addChild (mx)

Posted by GitBox <gi...@apache.org>.
tranquiliste commented on issue #903:
URL: https://github.com/apache/royale-asjs/issues/903#issuecomment-693864459


   Hello aharui,
   
   Thanks for the information, I looked at the branches and there are other differences compared to the nighlybuild which seem interresting.
   Why no merge has been done?
   
   Concerning a local build I need to see if it is difficult as my environment is not configured for that
   Nicolas


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] tranquiliste commented on issue #903: no automatic resizing after addChild (mx)

Posted by GitBox <gi...@apache.org>.
tranquiliste commented on issue #903:
URL: https://github.com/apache/royale-asjs/issues/903#issuecomment-691450653






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] aharui commented on issue #903: no automatic resizing after addChild (mx)

Posted by GitBox <gi...@apache.org>.
aharui commented on issue #903:
URL: https://github.com/apache/royale-asjs/issues/903#issuecomment-691403245






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] aharui commented on issue #903: no automatic resizing after addChild (mx)

Posted by GitBox <gi...@apache.org>.
aharui commented on issue #903:
URL: https://github.com/apache/royale-asjs/issues/903#issuecomment-691581160


   I don't think so.  Not sure what the plan is for that branch.  You could pull down the commits and build locally and see if it works for you, then propose a PR with those two commits.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] tranquiliste commented on issue #903: no automatic resizing after addChild (mx)

Posted by GitBox <gi...@apache.org>.
tranquiliste commented on issue #903:
URL: https://github.com/apache/royale-asjs/issues/903#issuecomment-694714792


   Hello @aharui I tried your fixes, it works for the addChild, but not for the remove (height is not re-calculated). I imagine this has to do with a childRemoved function, is that right? can you give me some direction for the fix?
   
   Nicolas


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] aharui commented on issue #903: no automatic resizing after addChild (mx)

Posted by GitBox <gi...@apache.org>.
aharui commented on issue #903:
URL: https://github.com/apache/royale-asjs/issues/903#issuecomment-691403245






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] tranquiliste edited a comment on issue #903: no automatic resizing after addChild (mx)

Posted by GitBox <gi...@apache.org>.
tranquiliste edited a comment on issue #903:
URL: https://github.com/apache/royale-asjs/issues/903#issuecomment-688073693


   Hello,
   
   I tried to look at the issue, but could not find  what's wrong. Height of DOM inside which we added the four labels is correctly calculated but not its parent.
   Is it a matter of adding a bead? if so I could not find which one.
   
   Any help would be appreciated.
   Thanks
   Nicolas


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] aharui commented on issue #903: no automatic resizing after addChild (mx)

Posted by GitBox <gi...@apache.org>.
aharui commented on issue #903:
URL: https://github.com/apache/royale-asjs/issues/903#issuecomment-691403245


   This appears to be fixed by commit 241c927e5b5ad5a8e7264b2e21072aa1be6fc959 in the ChildResize branch, although there was a bug with Panel that I just fixed with commit f59cbc30fe3e9acc8be59845ed1f18e97139666a


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] tranquiliste commented on issue #903: no automatic resizing after addChild (mx)

Posted by GitBox <gi...@apache.org>.
tranquiliste commented on issue #903:
URL: https://github.com/apache/royale-asjs/issues/903#issuecomment-695175860


   thanks very much, I am going to test that.
   
   Nicolas
   
   Le ven. 18 sept. 2020 à 20:17, aharui <no...@github.com> a écrit :
   
   > I went and fixed that in this commit: b01a9aa
   > <https://github.com/apache/royale-asjs/commit/b01a9aa83ea876a386695f78d043aca9ae749604>
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/royale-asjs/issues/903#issuecomment-695015292>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAACZHMEA2ZTQ5547UKHQE3SGOP4TANCNFSM4QXIRFBA>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] aharui commented on issue #903: no automatic resizing after addChild (mx)

Posted by GitBox <gi...@apache.org>.
aharui commented on issue #903:
URL: https://github.com/apache/royale-asjs/issues/903#issuecomment-691403245


   This appears to be fixed by commit 241c927e5b5ad5a8e7264b2e21072aa1be6fc959 in the ChildResize branch, although there was a bug with Panel that I just fixed with commit f59cbc30fe3e9acc8be59845ed1f18e97139666a


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] tranquiliste commented on issue #903: no automatic resizing after addChild (mx)

Posted by GitBox <gi...@apache.org>.
tranquiliste commented on issue #903:
URL: https://github.com/apache/royale-asjs/issues/903#issuecomment-688238646


   Hello me again,
   After further testing I resalized that if my parent DOM (Ecran2Class)  extends Panel rather than Box, the dispatchEvent( new FlexEvent("layoutNeeded")); has no effect.
   
   Nicolas


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] tranquiliste commented on issue #903: no automatic resizing after addChild (mx)

Posted by GitBox <gi...@apache.org>.
tranquiliste commented on issue #903:
URL: https://github.com/apache/royale-asjs/issues/903#issuecomment-691450653






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] tranquiliste commented on issue #903: no automatic resizing after addChild (mx)

Posted by GitBox <gi...@apache.org>.
tranquiliste commented on issue #903:
URL: https://github.com/apache/royale-asjs/issues/903#issuecomment-691450653


   Hello ,
   
   Thanks for the information. Have these 2 fixes been integrated in the
   nightly build?
   
   Nicolas
   
   Le sam. 12 sept. 2020 à 06:14, aharui <no...@github.com> a écrit :
   
   > This appears to be fixed by commit 241c927
   > <https://github.com/apache/royale-asjs/commit/241c927e5b5ad5a8e7264b2e21072aa1be6fc959>
   > in the ChildResize branch, although there was a bug with Panel that I just
   > fixed with commit f59cbc3
   > <https://github.com/apache/royale-asjs/commit/f59cbc30fe3e9acc8be59845ed1f18e97139666a>
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/royale-asjs/issues/903#issuecomment-691403245>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAACZHLKGQCMAFHI7IMS263SFLYRDANCNFSM4QXIRFBA>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org