You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yao Xu (Code Review)" <ge...@cloudera.org> on 2019/11/05 06:00:12 UTC
[kudu-CR] KUDU-1260 Add test for prefetching on java scanner
Yao Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14631
Change subject: KUDU-1260 Add test for prefetching on java scanner
......................................................................
KUDU-1260 Add test for prefetching on java scanner
Change-Id: Ia337724d04fba9eb83d0cc0d90fa1ef5c90150bb
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITFaultTolerantScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITNonFaultTolerantScanner.java
A java/kudu-client/src/test/java/org/apache/kudu/client/ITPrefetchingScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
5 files changed, 147 insertions(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/14631/1
--
To view, visit http://gerrit.cloudera.org:8080/14631
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia337724d04fba9eb83d0cc0d90fa1ef5c90150bb
Gerrit-Change-Number: 14631
Gerrit-PatchSet: 1
Gerrit-Owner: Yao Xu <oc...@gmail.com>
[kudu-CR] KUDU-1260 Add test for prefetching on java scanner
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14631 )
Change subject: KUDU-1260 Add test for prefetching on java scanner
......................................................................
Patch Set 2:
I'm not as qualified to review Java client code so I'll defer to Grant, but I want to reiterate the question I had in the other review: how does prefetching like this improve performance? Can you quantify it? What are you using to benchmark?
--
To view, visit http://gerrit.cloudera.org:8080/14631
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia337724d04fba9eb83d0cc0d90fa1ef5c90150bb
Gerrit-Change-Number: 14631
Gerrit-PatchSet: 2
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Comment-Date: Sat, 16 Nov 2019 00:47:25 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1260 Add test for prefetching on java scanner
Posted by "Yao Xu (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14631
to look at the new patch set (#2).
Change subject: KUDU-1260 Add test for prefetching on java scanner
......................................................................
KUDU-1260 Add test for prefetching on java scanner
Change-Id: Ia337724d04fba9eb83d0cc0d90fa1ef5c90150bb
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITFaultTolerantScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITNonFaultTolerantScanner.java
A java/kudu-client/src/test/java/org/apache/kudu/client/ITPrefetchingScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
5 files changed, 148 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/14631/2
--
To view, visit http://gerrit.cloudera.org:8080/14631
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia337724d04fba9eb83d0cc0d90fa1ef5c90150bb
Gerrit-Change-Number: 14631
Gerrit-PatchSet: 2
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
[kudu-CR] KUDU-1260 Add test for prefetching on java scanner
Posted by "Yao Xu (Code Review)" <ge...@cloudera.org>.
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14631 )
Change subject: KUDU-1260 Add test for prefetching on java scanner
......................................................................
Patch Set 1:
Hi, adar, grant.
I for prefetching scanner added some test and debug logs. I found that there were still some bugs, I tried to fix them, and now it seems to have been solved. However, I think it is better to run it 100 times through the tools to see if there are other problems.
--
To view, visit http://gerrit.cloudera.org:8080/14631
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia337724d04fba9eb83d0cc0d90fa1ef5c90150bb
Gerrit-Change-Number: 14631
Gerrit-PatchSet: 1
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Comment-Date: Tue, 05 Nov 2019 06:15:37 +0000
Gerrit-HasComments: No