You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2017/06/28 11:17:11 UTC

[Bug 61231] New: Remove deprecated AreaReference constructor

https://bz.apache.org/bugzilla/show_bug.cgi?id=61231

            Bug ID: 61231
           Summary: Remove deprecated AreaReference constructor
           Product: POI
           Version: 3.17-dev
          Hardware: PC
                OS: Mac OS X 10.1
            Status: NEW
          Severity: normal
          Priority: P2
         Component: SS Common
          Assignee: dev@poi.apache.org
          Reporter: fanningpj@yahoo.com
  Target Milestone: ---

Created attachment 35085
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=35085&action=edit
patch1

The major side effect is that we need to add SpreadsheetVersion in more of the
API. I will add a patch demonstrating the extra API changes that I am
proposing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 61231] Remove deprecated AreaReference constructor

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61231

PJ Fanning <fa...@yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35085|0                           |1
        is obsolete|                            |

--- Comment #1 from PJ Fanning <fa...@yahoo.com> ---
Created attachment 35086
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=35086&action=edit
patch2

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 61231] Remove deprecated AreaReference constructor

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61231

--- Comment #3 from PJ Fanning <fa...@yahoo.com> ---
Created attachment 35087
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=35087&action=edit
patch3 with CreationHelper changes

Thanks Nick for the review - patch3 has a change to the CreationHelper
interface.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 61231] Remove deprecated AreaReference constructor

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61231

--- Comment #4 from Nick Burch <ap...@gagravarr.org> ---
Comment on attachment 35087
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=35087
patch3 with CreationHelper changes

The unit tests look cleaner to me with the creation helper route, thanks for
working on that!

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 61231] Remove deprecated AreaReference constructor

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61231

--- Comment #2 from Nick Burch <ap...@gagravarr.org> ---
Might it make sense to either allow passing in a Workbook when creating an
AreaReference (to get the version from), or allowing creation of an
AreaReference from CreationHelper (to again get the version from) ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 61231] Remove deprecated AreaReference constructor

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61231

PJ Fanning <fa...@yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #5 from PJ Fanning <fa...@yahoo.com> ---
https://github.com/apache/poi/commit/51b46a9e4eb69205cae46fed5bce3badaecce3df

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 61231] Remove deprecated AreaReference constructor

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61231

--- Comment #6 from Dominik Stadler <do...@gmx.at> ---
Actual commit seems to be at
https://github.com/apache/poi/commit/5c65b55bd477868847bfc071bd95a5dd770e2741
and r1800208

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org