You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "alnzng (via GitHub)" <gi...@apache.org> on 2025/11/10 07:14:35 UTC

[PR] [hotfix] Add missing `mcp_server` in Java ResourceType API [flink-agents]

alnzng opened a new pull request, #312:
URL: https://github.com/apache/flink-agents/pull/312

   <!--
   * Thank you very much for contributing to Flink Agents.
   * Please add the relevant components in the PR title. E.g., [api], [runtime], [java], [python], [hotfix], etc.
   -->
   
   <!-- Please link the PR to the relevant issue(s). Hotfix doesn't need this. -->
   Linked issue: #xxx
   
   ### Purpose of change
   
   <!-- What is the purpose of this change? -->
   
   We need to define `mcp_server` in Java `ResourceType` API, otherwise below error could occur if the app integrates with MCP server:
   
   ```
   py4j.protocol.Py4JJavaError: An error occurred while calling o125.invoke.
   : java.lang.IllegalArgumentException: Unknown ResourceType value: mcp_server
   	at org.apache.flink.agents.api.resource.ResourceType.fromValue(ResourceType.java:58)
   	at org.apache.flink.agents.plan.serializer.ResourceProviderJsonDeserializer.deserializePythonSerializableResourceProvider(ResourceProviderJsonDeserializer.java:104)
   	at org.apache.flink.agents.plan.serializer.ResourceProviderJsonDeserializer.deserialize(ResourceProviderJsonDeserializer.java:66)
   	at org.apache.flink.agents.plan.serializer.ResourceProviderJsonDeserializer.deserialize(ResourceProviderJsonDeserializer.java:45)
   ```
   
   
   ### Tests
   
   <!-- How is this change verified? -->
   Deploy a test app in local Flink cluster
   
   ### API
   
   <!-- Does this change touches any public APIs? -->
   - Add new `mcp_server` in `ResourceType.java`
   
   ### Documentation
   
   <!-- Should this change be covered by the user documentation?-->
   n/a
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [hotfix] Add missing `mcp_server` in Java ResourceType API [flink-agents]

Posted by "wenjin272 (via GitHub)" <gi...@apache.org>.
wenjin272 commented on PR #312:
URL: https://github.com/apache/flink-agents/pull/312#issuecomment-3514806079

   Thanks for your work, @alnzng, LGTM. 
   
   Sorry for I forgot add the correspond resource type when introduce mcp in python side. I'm working on cleaning up the e2e tests and running them in CI. After this work done, if we have corresponding test cases, this issue could be exposed earlier.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [hotfix] Add missing `mcp_server` in Java ResourceType API [flink-agents]

Posted by "Sxnan (via GitHub)" <gi...@apache.org>.
Sxnan merged PR #312:
URL: https://github.com/apache/flink-agents/pull/312


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [hotfix] Add missing `mcp_server` in Java ResourceType API [flink-agents]

Posted by "alnzng (via GitHub)" <gi...@apache.org>.
alnzng commented on PR #312:
URL: https://github.com/apache/flink-agents/pull/312#issuecomment-3509794707

   @wenjin272 @xintongsong please take a look this PR, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [hotfix] Add missing `mcp_server` in Java ResourceType API [flink-agents]

Posted by "alnzng (via GitHub)" <gi...@apache.org>.
alnzng commented on PR #312:
URL: https://github.com/apache/flink-agents/pull/312#issuecomment-3553403102

   @Sxnan could you help take a look this and merge it if no concern from you?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [hotfix] Add missing `mcp_server` in Java ResourceType API [flink-agents]

Posted by "alnzng (via GitHub)" <gi...@apache.org>.
alnzng commented on PR #312:
URL: https://github.com/apache/flink-agents/pull/312#issuecomment-3518401176

   That sounds great, @wenjin272 ! I did find some other issues / bugs while I was doing the integration with current code base, I can also contribute them to the tests once we have test infra ready.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org