You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/07/24 17:46:36 UTC

[GitHub] [camel-k] nicolaferraro opened a new pull request #1637: Add support for sinkbinding

nicolaferraro opened a new pull request #1637:
URL: https://github.com/apache/camel-k/pull/1637


   <!-- Description -->
   
   Requires: https://github.com/apache/camel-k-runtime/pull/411
   
   Tasks:
   - [x] Add sinkbinding option in knative trait
   - [ ] Implement scenario 2 in the issue
   - [ ] E2E tests
   - [ ] Regen docs
   
   <!--
   Enter your extended release note in the below block. If the PR requires
   additional action from users switching to the new release, include the string
   "action required". If no release note is required, write "NONE". 
   
   You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
   the text is added to the right section of the release notes. 
   -->
   
   **Release Note**
   ```release-note
   Standard integrations can now create a sinkbinding to be listed as Knative sources
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] nicolaferraro merged pull request #1637: Add support for sinkbinding

Posted by GitBox <gi...@apache.org>.
nicolaferraro merged pull request #1637:
URL: https://github.com/apache/camel-k/pull/1637


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] nicolaferraro commented on pull request #1637: Add support for sinkbinding

Posted by GitBox <gi...@apache.org>.
nicolaferraro commented on pull request #1637:
URL: https://github.com/apache/camel-k/pull/1637#issuecomment-669812820


   > @nicolaferraro do you have an example of a sinkbinding declaration with a regular integration?
   
   @heiko-braun this is an (working) integration that results as a regular Knative source:
   
   ```yaml
   apiVersion: camel.apache.org/v1
   kind: Integration
   metadata:
     name: source
   spec:
     flows:
     - from:
         uri: timer:tick
         parameters:
           period: "1000"
         steps:
         - set-body:
             constant: Hello SinkBinding !!!
         - transform:
             simple: ${body.toUpperCase()}
         - to: log:info
           # the following line may also be split into k/v format (to be implemented)
         - to: knative:channel/messages?apiVersion=messaging.knative.dev/v1beta1&kind=InMemoryChannel
     traits:
       knative:
         configuration:
           sinkBinding: true # we may default it to true in the future to avoid this setting
   ```
   
   A **future** simplified version may look like:
   
   ```yaml
   apiVersion: camel.apache.org/v1
   kind: Integration
   metadata:
     name: source
   spec:
     flows:
     - from:
         uri: timer:tick
         parameters:
           period: "1000"
         steps:
         - set-body:
             constant: Hello SinkBinding !!!
         - transform:
             simple: ${body.toUpperCase()}
         - to: log:info
         - to:
             uri: knative:endpoint
             parameters:
               apiVersion: messaging.knative.dev/v1beta1
               kind: InMemoryChannel
               name: messages
   ```
   
   Which is very close to the equivalent CamelSource (current working implementation):
   
   ```yaml
   apiVersion: sources.knative.dev/v1alpha1
   kind: CamelSource
   metadata:
     name: source
   spec:
     source:
       flow:
         from:
           uri: timer:tick
           parameters:
             period: "1000"
           steps:
           - set-body:
               constant: Hello Old CamelSource !!!
           - transform:
               simple: ${body.toUpperCase()}
           - to: log:info
     sink:
       ref:
         apiVersion: messaging.knative.dev/v1beta1
         kind: InMemoryChannel
         name: messages
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] heiko-braun commented on pull request #1637: Add support for sinkbinding

Posted by GitBox <gi...@apache.org>.
heiko-braun commented on pull request #1637:
URL: https://github.com/apache/camel-k/pull/1637#issuecomment-663686116


   @nicolaferraro do you have an example of a sinkbinding declaration with a regular integration?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org