You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/01 04:52:11 UTC

[GitHub] [tvm] mbrookhart commented on pull request #7550: [Relay] Fix foldconstant involving dropout

mbrookhart commented on pull request #7550:
URL: https://github.com/apache/tvm/pull/7550#issuecomment-787634639


   I thought about this over the weekend. I agree that this is the right solution. Fold-Constant doesn't assume training or inference, it's more general, and in the training case, dropout should never be folded. Additionally, the VM and the GraphRuntime both run FoldConstant after SimplifyInference, so this shouldn't hurt inference performance.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org