You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/05/28 11:46:59 UTC

[GitHub] [incubator-pekko-persistence-jdbc] mdedetrich opened a new pull request, #48: Set version scheme

mdedetrich opened a new pull request, #48:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/48

   Self explanatory


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-persistence-jdbc] mdedetrich merged pull request #48: Set version scheme

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #48:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/48


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-persistence-jdbc] mdedetrich commented on a diff in pull request #48: Set version scheme

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #48:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/48#discussion_r1209198572


##########
build.sbt:
##########
@@ -5,6 +5,7 @@ import sbt.Keys._
 ThisBuild / resolvers += Resolver.ApacheMavenSnapshotsRepo
 
 ThisBuild / apacheSonatypeProjectProfile := "pekko"
+ThisBuild / versionScheme := Some("semver-spec")

Review Comment:
   I don't think this is part of sbt?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-persistence-jdbc] He-Pin commented on a diff in pull request #48: Set version scheme

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #48:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/48#discussion_r1209000861


##########
build.sbt:
##########
@@ -5,6 +5,7 @@ import sbt.Keys._
 ThisBuild / resolvers += Resolver.ApacheMavenSnapshotsRepo
 
 ThisBuild / apacheSonatypeProjectProfile := "pekko"
+ThisBuild / versionScheme := Some("semver-spec")

Review Comment:
   Maybe Some("semver-spec") can be something like `Some(VersionScheme.semver)`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org