You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2012/07/03 10:18:47 UTC
git commit: WICKET-4635 Improve JavaScript files by applying common
JSHint rules
Updated Branches:
refs/heads/master 2a875737a -> 28ff8a23f
WICKET-4635 Improve JavaScript files by applying common JSHint rules
Add wicketatmosphere.js to the list of linted files.
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/28ff8a23
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/28ff8a23
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/28ff8a23
Branch: refs/heads/master
Commit: 28ff8a23faf519d05fb9cba31af99fa5cc474b55
Parents: 2a87573
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Tue Jul 3 10:17:39 2012 +0200
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Tue Jul 3 10:17:39 2012 +0200
----------------------------------------------------------------------
grunt.js | 4 +++
.../wicket/atmosphere/jquery.wicketatmosphere.js | 22 +++++++--------
2 files changed, 14 insertions(+), 12 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/28ff8a23/grunt.js
----------------------------------------------------------------------
diff --git a/grunt.js b/grunt.js
index 5ceb796..3161745 100644
--- a/grunt.js
+++ b/grunt.js
@@ -38,6 +38,9 @@ module.exports = function(grunt) {
nativeWebSocketJs = [
"wicket-experimental/wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/api/res/js/wicket-websocket-jquery.js"
],
+ atmosphereJs = [
+ "wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/jquery.wicketatmosphere.js"
+ ],
gruntJs = [
"grunt.js"
];
@@ -49,6 +52,7 @@ module.exports = function(grunt) {
extensions: extensionsJs,
datetime: datetimeJs,
nativeWebSocket: nativeWebSocketJs,
+ atmosphere: atmosphereJs,
grunt: gruntJs
},
http://git-wip-us.apache.org/repos/asf/wicket/blob/28ff8a23/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/jquery.wicketatmosphere.js
----------------------------------------------------------------------
diff --git a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/jquery.wicketatmosphere.js b/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/jquery.wicketatmosphere.js
index 8583ea0..7b193ba 100644
--- a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/jquery.wicketatmosphere.js
+++ b/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/jquery.wicketatmosphere.js
@@ -1,21 +1,19 @@
-(function($) {
+;(function($) {
+ 'use strict';
+
jQuery.fn.wicketAtmosphere = function(params) {
var callbackAdded = false;
var response;
// jquery.atmosphere.response
function callback(response) {
- detectedTransport = response.transport;
- if (response.transport != 'polling'
- && response.state == 'messageReceived') {
- $.atmosphere.log('info', [ "response.responseBody: "
- + response.responseBody ]);
- if (response.status == 200) {
- (new Wicket.Ajax.Call()).loadedCallback($
- .parseXML(response.responseBody), {});
- }
- } else if (response.state == "opening") {
+ if (response.transport !== 'polling' && response.state === 'messageReceived') {
+ $.atmosphere.log('info', [ "response.responseBody: " + response.responseBody ]);
+ if (response.status === 200) {
+ (new Wicket.Ajax.Call()).loadedCallback($.parseXML(response.responseBody), {});
+ }
+ } else if (response.state === "opening") {
}
}
@@ -34,5 +32,5 @@
callbackAdded = false;
$.atmosphere.unsubscribe();
});
- }
+ };
}(jQuery));
\ No newline at end of file