You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/24 06:45:34 UTC
[GitHub] [arrow-datafusion] gaojun2048 commented on a change in pull request #1659: [Ballista] Add Decimal128, Date64, TimestampSecond, TimestampMillisecond, Interv…
gaojun2048 commented on a change in pull request #1659:
URL: https://github.com/apache/arrow-datafusion/pull/1659#discussion_r790450902
##########
File path: ballista/rust/core/proto/ballista.proto
##########
@@ -1179,9 +1179,21 @@ message ScalarValue{
ScalarType null_list_value = 18;
PrimitiveScalarType null_value = 19;
+ Decimal128 decimal128_value = 20;
+ int64 date_64_value = 21;
+ int64 time_second_value = 22;
+ int64 time_millisecond_value = 23;
+ int32 interval_yearmonth_value = 24;
+ int64 interval_daytime_value = 25;
}
}
+message Decimal128{
+ string value = 1;
Review comment:
> I'm confused about this point, we use the `String` type to hold the value of Decimal.
The value type is `i128` in datafusion Decimal128, But I don't know how to define i128 in proto. Or is it possible to use int64 in proto?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org