You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/08/03 06:03:08 UTC

[GitHub] [helix] narendly commented on a change in pull request #1205: Fix mvn site failure

narendly commented on a change in pull request #1205:
URL: https://github.com/apache/helix/pull/1205#discussion_r464209419



##########
File path: pom.xml
##########
@@ -651,14 +651,7 @@ under the License.
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-site-plugin</artifactId>
-        <version>3.2</version>
-        <dependencies>
-          <dependency>
-            <groupId>org.apache.maven.doxia</groupId>
-            <artifactId>doxia-module-markdown</artifactId>
-            <version>1.3</version>
-          </dependency>
-        </dependencies>
+        <version>3.9.1</version>

Review comment:
       There is a reason why we keep the doxia plugin at 3.2. I've attempted to upgrade the doxia plugin to the latest a while ago, and although you see the mvn site command pass, it will end up generating a broken website. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org