You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by soralee <gi...@git.apache.org> on 2017/03/24 04:52:09 UTC
[GitHub] zeppelin pull request #2186: [ZEPPELIN-2229] revert ndv3 version from 1.8.5 ...
GitHub user soralee opened a pull request:
https://github.com/apache/zeppelin/pull/2186
[ZEPPELIN-2229] revert ndv3 version from 1.8.5 to 1.7.1
### What is this PR for?
After [[ZEPPELIN-1588]: bumping nvd3 to 1.8.5](#2042) merged, Zeppelin was occurring front-end side error such as `Uncaught TypeError: Cannot read property 'x' of null` because of upgrading for `1.7.1` to `1.8.5`.
AFAIK, this is a bug in `ndv3`, and ndv3 is still fixing the problem discussing [here](https://github.com/novus/nvd3/issues/330).
Also The latest release(1.8.5 version) scatter file and the master scatter file have a lot of changes, so we should wait for the next release.
Thus, I think we need to revert version from 1.8.5 to 1.7.1 for stable Zeppelin and our next 0.7.1 release.
_Plus, when I check on current master of nvd3, scatter chart works well like this._
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* [ZEPPELIN-2229](https://issues.apache.org/jira/browse/ZEPPELIN-2229)
### How should this be tested?
* Switch some of chart such like screenshots.
### Screenshots (if appropriate)
[Before]
[After]
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/soralee/zeppelin ZEPPELIN-2229_x_of_null
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2186.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2186
----
commit 7dfdd8c016d57a385eb8a886c1d829b7da169856
Author: soralee <so...@zepl.com>
Date: 2017-03-24T04:25:11Z
[ZEPPELIN-2229] changed scatter and pie charts according to reverted version
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2186: [ZEPPELIN-2229] revert ndv3 version from 1.8.5 to 1.7....
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2186
@soralee Yeah I can see the error when we have large data.
I tested it in release `0.7.1-rc2` bin package. Can you mention this PR with short description in `0.7.1-rc2` release vote? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2186: [ZEPPELIN-2229] revert ndv3 version from 1.8.5 ...
Posted by soralee <gi...@git.apache.org>.
Github user soralee closed the pull request at:
https://github.com/apache/zeppelin/pull/2186
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2186: [ZEPPELIN-2229] revert ndv3 version from 1.8.5 to 1.7....
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2186
@AhyoungRyu This PR reverted some of #2042 and I didn't include to change [this line]( https://github.com/apache/zeppelin/pull/2042/files#diff-7a20bcbe25109dfb2ad811a62a366cbeL63).
If we decide to revert # 2042, I can give you help to check the reverted code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2186: [ZEPPELIN-2229] revert ndv3 version from 1.8.5 to 1.7....
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2186
Let's move on #2194 PR!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2186: [ZEPPELIN-2229] revert ndv3 version from 1.8.5 to 1.7....
Posted by anthonycorbacho <gi...@git.apache.org>.
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/2186
I will agree with @Remilito on this one.
I think we can come up with a workaround and keep 1.8.5.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2186: [ZEPPELIN-2229] revert ndv3 version from 1.8.5 to 1.7....
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2186
I closed this PR. Because In the better way which keeps on the latest version, @Remilito suggested #2194, I think we don't need to talk about this PR any more.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2186: [ZEPPELIN-2229] revert ndv3 version from 1.8.5 to 1.7....
Posted by Remilito <gi...@git.apache.org>.
Github user Remilito commented on the issue:
https://github.com/apache/zeppelin/pull/2186
@soralee , @AhyoungRyu , @anthonycorbacho : proposal of workaround here, https://github.com/apache/zeppelin/pull/2194 . Feedbacks welcome!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2186: [ZEPPELIN-2229] revert ndv3 version from 1.8.5 to 1.7....
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2186
@AhyoungRyu I did! Thanks for reproduce!
Let me check this part I didn't include. If it is possible, we had better revert it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2186: [ZEPPELIN-2229] revert ndv3 version from 1.8.5 to 1.7....
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2186
@Remilito @anthonycorbacho Thanks for opinions!
Yeah, I think whatever we use 1.7.1 version or 1.8.5 versions, we have a lot of bugs. `nvd3` release process is too slow and, I'm not sure 1.8.5 version has critical bugs than 1.7.1 version :disappointed:
If we don't mind those issues, we would be nice to keep the latest version!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2186: [ZEPPELIN-2229] revert ndv3 version from 1.8.5 to 1.7....
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2186
@Remilito Will be appreciated if you can take a look this :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2186: [ZEPPELIN-2229] revert ndv3 version from 1.8.5 to 1.7....
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2186
@soralee Thanks for digging it up!
Seems https://github.com/novus/nvd3/pull/1934 fixed this issue and merged in Jan. Hopefully they have a plan to release another minor version soon including this fix.
>Thus, I think we need to revert version from 1.8.5 to 1.7.1 for stable Zeppelin and our next 0.7.1
Then we can just revert #2042 commit from `branch-0.7`(and `master`?) instead of opening another PR and merging it. @Leemoonsoo What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2186: [ZEPPELIN-2229] revert ndv3 version from 1.8.5 to 1.7....
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2186
@AhyoungRyu @Leemoonsoo I just checked it!
We can either revert or merge it. the part I didn't include don't matter.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2186: [ZEPPELIN-2229] revert ndv3 version from 1.8.5 to 1.7....
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2186
@soralee And as you can see in the above gif image that i took, the tooltip in scatter chart is shown like "(age, value)". But before #2042 it looks like below.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2186: [ZEPPELIN-2229] revert ndv3 version from 1.8.5 to 1.7....
Posted by Remilito <gi...@git.apache.org>.
Github user Remilito commented on the issue:
https://github.com/apache/zeppelin/pull/2186
My 2 cts here:
Yep the scatter chart bug in 1.8.5 is annoying, and unfortunately nvd3 does not seem to release very frequently ( 2-3 times a year or so). However I am not sure reverting the lib from 1.8.5 to 1.7.1 is the right move, keep in mind that **a lot of bugs** were fixed between those two releases.
Reverting to 1.7.1 is very likely to reintroduce (or maintain) a lot of others bugs.
I wonder if we could do something directly in Zeppelin's visualization code to workaround the voronoi issue you spotted until 1.8.6 is released. Your thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2186: [ZEPPELIN-2229] revert ndv3 version from 1.8.5 to 1.7....
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2186
@AhyoungRyu I checked [your comment about translate error](https://github.com/apache/zeppelin/pull/2186#issuecomment-289178564).
The error seems to be caused by incompatibility with the 1.7.1 version and [this line](https://github.com/apache/zeppelin/pull/2129/files#diff-28a8fa162a27698e421ee716f1822a33L73) that is after merged this #2129 in master branch.
If we decide merge, I would fix issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2186: [ZEPPELIN-2229] revert ndv3 version from 1.8.5 to 1.7....
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2186
@AhyoungRyu Thanks for detail test! Let me check this and leave comment!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2186: [ZEPPELIN-2229] revert ndv3 version from 1.8.5 to 1.7....
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2186
@soralee Thanks for the explanation.
I tested this branch to make sure it works well or not, but when I select "Line chart" below error msg shows up.
```
vendor.bcb986b75e1664c0.js:64 Error: <g> attribute transform: Trailing garbage, "translate(813,NaN)".
```
I checked multiple times, but I could see this every time. Could you check this please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---