You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by gg...@apache.org on 2018/08/08 14:38:13 UTC
httpcomponents-core git commit: Consistently clean exception
messages. Also: MessageConstraintException does not need its own message
field.
Repository: httpcomponents-core
Updated Branches:
refs/heads/master 206cbe9a0 -> 5c838ce57
Consistently clean exception messages. Also: MessageConstraintException
does not need its own message field.
Project: http://git-wip-us.apache.org/repos/asf/httpcomponents-core/repo
Commit: http://git-wip-us.apache.org/repos/asf/httpcomponents-core/commit/5c838ce5
Tree: http://git-wip-us.apache.org/repos/asf/httpcomponents-core/tree/5c838ce5
Diff: http://git-wip-us.apache.org/repos/asf/httpcomponents-core/diff/5c838ce5
Branch: refs/heads/master
Commit: 5c838ce57d641ffb0bb97438c66531e4f038c2fe
Parents: 206cbe9
Author: Gary Gregory <ga...@gmail.com>
Authored: Wed Aug 8 08:38:09 2018 -0600
Committer: Gary Gregory <ga...@gmail.com>
Committed: Wed Aug 8 08:38:09 2018 -0600
----------------------------------------------------------------------
.../core5/http/ConnectionRequestTimeoutException.java | 2 +-
.../apache/hc/core5/http/ContentTooLongException.java | 2 +-
.../hc/core5/http/MessageConstraintException.java | 9 +--------
.../apache/hc/core5/http/NoHttpResponseException.java | 14 ++++++++++++++
.../apache/hc/core5/http/TruncatedChunkException.java | 2 +-
5 files changed, 18 insertions(+), 11 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/httpcomponents-core/blob/5c838ce5/httpcore5/src/main/java/org/apache/hc/core5/http/ConnectionRequestTimeoutException.java
----------------------------------------------------------------------
diff --git a/httpcore5/src/main/java/org/apache/hc/core5/http/ConnectionRequestTimeoutException.java b/httpcore5/src/main/java/org/apache/hc/core5/http/ConnectionRequestTimeoutException.java
index ee82bbf..5847433 100644
--- a/httpcore5/src/main/java/org/apache/hc/core5/http/ConnectionRequestTimeoutException.java
+++ b/httpcore5/src/main/java/org/apache/hc/core5/http/ConnectionRequestTimeoutException.java
@@ -49,7 +49,7 @@ public class ConnectionRequestTimeoutException extends InterruptedIOException {
* @param message the exception detail message, or {@code null}
*/
public ConnectionRequestTimeoutException(final String message) {
- super(message);
+ super(HttpException.clean(message));
}
}
http://git-wip-us.apache.org/repos/asf/httpcomponents-core/blob/5c838ce5/httpcore5/src/main/java/org/apache/hc/core5/http/ContentTooLongException.java
----------------------------------------------------------------------
diff --git a/httpcore5/src/main/java/org/apache/hc/core5/http/ContentTooLongException.java b/httpcore5/src/main/java/org/apache/hc/core5/http/ContentTooLongException.java
index a2e4504..8da1bbd 100644
--- a/httpcore5/src/main/java/org/apache/hc/core5/http/ContentTooLongException.java
+++ b/httpcore5/src/main/java/org/apache/hc/core5/http/ContentTooLongException.java
@@ -44,7 +44,7 @@ public class ContentTooLongException extends IOException {
* @param message exception message
*/
public ContentTooLongException(final String message) {
- super(message);
+ super(HttpException.clean(message));
}
}
http://git-wip-us.apache.org/repos/asf/httpcomponents-core/blob/5c838ce5/httpcore5/src/main/java/org/apache/hc/core5/http/MessageConstraintException.java
----------------------------------------------------------------------
diff --git a/httpcore5/src/main/java/org/apache/hc/core5/http/MessageConstraintException.java b/httpcore5/src/main/java/org/apache/hc/core5/http/MessageConstraintException.java
index 8084b6d..278e52b 100644
--- a/httpcore5/src/main/java/org/apache/hc/core5/http/MessageConstraintException.java
+++ b/httpcore5/src/main/java/org/apache/hc/core5/http/MessageConstraintException.java
@@ -38,21 +38,14 @@ public class MessageConstraintException extends IOException {
private static final long serialVersionUID = 6077207720446368695L;
- private final String message;
-
/**
* Creates a MessageConstraintException with the specified detail message.
*
* @param message The exception detail message
*/
public MessageConstraintException(final String message) {
- super();
- this.message = message;
+ super(HttpException.clean(message));
}
- @Override
- public String getMessage() {
- return this.message;
- }
}
http://git-wip-us.apache.org/repos/asf/httpcomponents-core/blob/5c838ce5/httpcore5/src/main/java/org/apache/hc/core5/http/NoHttpResponseException.java
----------------------------------------------------------------------
diff --git a/httpcore5/src/main/java/org/apache/hc/core5/http/NoHttpResponseException.java b/httpcore5/src/main/java/org/apache/hc/core5/http/NoHttpResponseException.java
index 5fc880e..d482b8b 100644
--- a/httpcore5/src/main/java/org/apache/hc/core5/http/NoHttpResponseException.java
+++ b/httpcore5/src/main/java/org/apache/hc/core5/http/NoHttpResponseException.java
@@ -47,4 +47,18 @@ public class NoHttpResponseException extends IOException {
super(HttpException.clean(message));
}
+ /**
+ * Constructs a {@code NoHttpResponseException} with the specified detail message
+ * and cause.
+ *
+ * @param message The exception detail message
+ * @param cause The cause.
+ *
+ * @since 5.0
+ */
+ public NoHttpResponseException(final String message, final Throwable cause) {
+ super(message, cause);
+ }
+
+
}
http://git-wip-us.apache.org/repos/asf/httpcomponents-core/blob/5c838ce5/httpcore5/src/main/java/org/apache/hc/core5/http/TruncatedChunkException.java
----------------------------------------------------------------------
diff --git a/httpcore5/src/main/java/org/apache/hc/core5/http/TruncatedChunkException.java b/httpcore5/src/main/java/org/apache/hc/core5/http/TruncatedChunkException.java
index 58b7390..446b715 100644
--- a/httpcore5/src/main/java/org/apache/hc/core5/http/TruncatedChunkException.java
+++ b/httpcore5/src/main/java/org/apache/hc/core5/http/TruncatedChunkException.java
@@ -42,7 +42,7 @@ public class TruncatedChunkException extends MalformedChunkCodingException {
* @param message The exception detail message
*/
public TruncatedChunkException(final String message) {
- super(message);
+ super(HttpException.clean(message));
}
}