You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2026/08/29 21:50:58 UTC

[GH] (pekko-connectors/fix-orientdb-classname-query): Workflow run "CI" is working again!

The GitHub Actions job "CI" on pekko-connectors.git/fix-orientdb-classname-query has succeeded.
Run started by GitHub user pjfanning (triggered by pjfanning).

Head commit for run:
0da2f4bd05b44b44a3cbf8a4b9ec86b44fe58af1 / PJ Fanning <pj...@users.noreply.github.com>
OrientDB: only validate className when it is used in a query

Motivation:
OrientDbSourceStage validates className in its constructor
unconditionally, including when an explicit query is supplied. In that
case className is never used: createLogic ignores it in both query
branches, and the SELECT that interpolates it is only built when query is
empty.

Both DSLs require className as a positional argument, so a caller reading
purely by query must pass a syntactically valid dummy class name to get
past a check that guards a string their query never reaches.

Modification:
Validate only when query is empty, which is exactly when className is
interpolated into "SELECT * FROM $className".

Result:
Query-only reads no longer need a placeholder class name. The injection
guard is unchanged wherever className actually reaches SQL.

Tests:
Extended OrientDbSourceStageSpec with stage-level tests: an invalid class
name is still rejected with no query, a valid one is accepted, and a
class name that is empty, null, or malformed is accepted when a query is
given. Verified the query-mode test fails without this change. 11 tests
pass. Ran orientdb/mimaReportBinaryIssues (clean) and the module scalafmt
checks.

References:
Follow-up to #1821.

Report URL: https://github.com/apache/pekko-connectors/actions/runs/33275943862

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org