You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by ramkrish86 <gi...@git.apache.org> on 2016/03/14 13:43:13 UTC
[GitHub] flink pull request: Flink 3579 Improve String concatenation
GitHub user ramkrish86 opened a pull request:
https://github.com/apache/flink/pull/1788
Flink 3579 Improve String concatenation
I have added some test cases that solves both the String concat with '+' operator and the problem with 'cast' operator. Do let me know what you think of this.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ramkrish86/flink FLINK-3579
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1788.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1788
----
commit ed6cc91e227bc6b053ca9e0142a680f6301bdaf6
Author: Fabian Hueske <fh...@apache.org>
Date: 2016-01-15T16:46:39Z
[FLINK-3223] Translate Table API calls to Calcite RelNodes.
This is an intermediate step to port the Table API on top of Calcite (FLINK-3221).
This commit:
- Adds Calcite as dependency to flink-table.
- Translates Table API calls directly into Calcite RelNodes.
- Modifies tests to check only the translation into logical plans but not the execution of Table API queries.
- Deactivates a few tests that are not supported yet.
- Removes a lot of the former Table API translation code.
- Removes bitwise operators from the Table API.
commit 4abca1d0e3bba30f6adee39f9b278020fdf0f4fc
Author: Fabian Hueske <fh...@apache.org>
Date: 2016-01-25T14:34:24Z
Renamed Table.scala to table.scala
commit fe5e4065643dcb208f3990897f171780311502e9
Author: Fabian Hueske <fh...@apache.org>
Date: 2016-01-26T12:22:38Z
[FLINK-3225] Implemented optimization of Table API queries via Calcite
- added logical Flink nodes and translation rules
- added stubs for DataSet translation rules
- ported DataSetNodes to Scala
- reactivated tests and added expected NotImplementedError
commit 20235e0afaf5de799e71094d72ae7e47337ea82d
Author: chengxiang li <ch...@intel.com>
Date: 2016-01-27T03:37:43Z
[FLINK-3282] add FlinkRelNode interface.
commit 6dd2d779d18113034311f13512deb5a7afbf885e
Author: chengxiang li <ch...@intel.com>
Date: 2016-02-01T07:18:14Z
[Flink-3226] Translate logical plan FlinkRels into physical plan DataSetRels.
commit 3cb76fcbcc997e975ac7f1589c9f65d83dfd0137
Author: Fabian Hueske <fh...@apache.org>
Date: 2016-02-01T22:45:16Z
[FLINK-3225] Enforce translation to DataSetNodes
commit 99f60c84092a5c656591d68f4d4450f14f88b9ba
Author: Fabian Hueske <fh...@apache.org>
Date: 2016-02-02T16:15:28Z
[FLINK-3226] Add DataSet scan and conversion to DataSet[Row]
This closes #1579.
commit 18e7f2f4e0654ad2f00dcf7d1351846345accb13
Author: vasia <va...@apache.org>
Date: 2016-02-04T14:53:52Z
[FLINK-3226] implement GroupReduce translation; enable tests for supported operations
Squashes the following commits:
- Compute average as sum and count for byte, short and int type to avoid rounding errors
- Move aggregation functions to org.apache.flink.table.runtime
- Remove join-related changes
- Change integer average aggregations to maintain sum and count
- Long average uses a BigInteger sum
commit a4ad9dd566353c578ad660fda7039757a605f27d
Author: twalthr <tw...@apache.org>
Date: 2016-02-05T16:40:54Z
[FLINK-3226] Implement a CodeGenerator for an efficient translation to DataSet programs
This closes #1595
commit e742826326c2719f2f5e06a5e4020f743c3278f9
Author: vasia <va...@apache.org>
Date: 2016-02-11T13:24:24Z
[FLINK-3226] implement getUniqueName method in TranslationContext
This closes #1600 and #1567
commit 7233c241d3858d2b751b0fddf379b7b6819b48ba
Author: twalthr <tw...@apache.org>
Date: 2016-02-11T15:16:29Z
[FLINK-3226] Translation from and to POJOs for CodeGenerator
This closes #1624
commit abbedc324e67b6701546239b68203f0d89a7e526
Author: vasia <va...@apache.org>
Date: 2016-02-11T17:04:45Z
[FLINK-3226] Translate logical joins to physical
This closes #1632
commit 9d765d0833cabfa6edd4097668b6ea7bd182ad76
Author: twalthr <tw...@apache.org>
Date: 2016-02-13T11:38:12Z
[FLINK-3226] Casting support for arithmetic operators
commit 1c53c873a4ea2ad180e5d2e839b226e84c468c49
Author: twalthr <tw...@apache.org>
Date: 2016-02-15T16:00:41Z
[FLINK-3226] Translation of explicit casting
commit 3e22074553cedde1c3a1754d91d26a9f35ac3c2f
Author: twalthr <tw...@apache.org>
Date: 2016-02-20T20:41:44Z
[FLINK-3226] Translation of scalar function substring()
commit 72686231fd8f9fa6a1c05df48f6f29eaa3ca4f2b
Author: chengxiang li <ch...@intel.com>
Date: 2016-02-25T09:45:09Z
[FLINK-3508] Add more test cases to verify the rules of logical plan optimization.
commit 61bc3a2d5564059299ec382908520e39c1976183
Author: vasia <va...@apache.org>
Date: 2016-02-22T14:06:37Z
[FLINK-3463] implement calc translation
- remove FlinkFilter, FlinkProject and associated rules
- deactivate FilterReduceExpressionsRule and ProjectReduceExpressionsRule
(covered by CalcReduceExpressions)
This closes #1696
commit 2b36401d4cca381188e5adb87206d0ba4a08ccd7
Author: twalthr <tw...@apache.org>
Date: 2016-02-25T08:36:32Z
[FLINK-3226] Improvements for expected types
This closes #1709
commit 4a63e29142e492d07ec42ab949f6c8d98f0b9c71
Author: vasia <va...@apache.org>
Date: 2016-02-25T19:52:19Z
[FLINK-3482] implement union translation
- implement custom JoinUnionTransposeRules
because Calcite's only match with LogicalUnion
This closes #1715
commit e097cf7dbbeec6ecbd77e77842c1c869ae40de1b
Author: Fabian Hueske <fh...@apache.org>
Date: 2016-02-26T14:53:19Z
[FLINK-3502] Add test case. Bug was resolved by a previous commit.
commit 031d6f745fe63e1c089055b825f7816b91b8433b
Author: Fabian Hueske <fh...@apache.org>
Date: 2016-02-29T13:46:08Z
[FLINK-3504] Fix join translation. Equality predicates may only reference fields.
Catch Calcite planner exception and rethrow with additional error message
This closes #1734
commit c57e2415fdeac80f8c851f7ddb4fabe7a1781836
Author: Fabian Hueske <fh...@apache.org>
Date: 2016-02-29T14:00:06Z
[FLINK-3537] Fix code gen for disjunctions.
This closes #1733
commit 5fe9357feddcd312a311d1bdab0b8fc178fadcfe
Author: Fabian Hueske <fh...@apache.org>
Date: 2016-02-29T15:34:24Z
[FLINK-3486] [tableAPI] Fix broken renaming of all fields.
commit d940c36639f31fa36b062a4683300af3b11a2ccb
Author: twalthr <tw...@apache.org>
Date: 2016-03-01T09:24:41Z
[FLINK-3498] Implement TRIM, SUBSTRING as reference design for Table API
commit 16637d1f419b18daa60fe723cc51082c937638c0
Author: Fabian Hueske <fh...@apache.org>
Date: 2016-03-04T08:51:19Z
[FLINK-3567] Fix selection on grouping. Only grouping keys or aggregates allowed.
This closes #1761
commit 3cb012140cf62a40a5f9c42ffeeb5b244089300b
Author: twalthr <tw...@apache.org>
Date: 2016-03-02T12:19:38Z
[FLINK-3564] [table] Implement distinct() for Table API
This closes #1754
commit 2fcdad96abc9276d640d53d2fa670e8bf643a8b3
Author: chengxiang li <ch...@intel.com>
Date: 2016-03-08T07:13:28Z
[FLINK-3474]: Enable partial aggregate in Table API
-- add new Aggregate interface which support partial aggregate
-- implement SUM/COUNT/AVG/MIN/MAX aggregate functions implementation
-- sorted-based runtime support
this closes #1746
commit e9b9b6f3a61ac18b92b183408abf85aa243ccb54
Author: twalthr <tw...@apache.org>
Date: 2016-03-04T10:37:58Z
[FLINK-3573] [table] Implement more String functions for Table API
commit e34e439549910761a19676ae6659add5233ddf1a
Author: Fabian Hueske <fh...@apache.org>
Date: 2016-03-08T19:35:54Z
[FLINK-3593][tableAPI] Fix failing DistinctITCase
commit 8a958b99c9bc593c80778f82950b1a84a2753386
Author: ramkrishna <ra...@gmail.com>
Date: 2016-03-14T12:39:40Z
FLINK-3579 Improve String concatenation (Ramkrishna)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Flink 3579 Improve String concatenation
Posted by ramkrish86 <gi...@git.apache.org>.
Github user ramkrish86 commented on the pull request:
https://github.com/apache/flink/pull/1788#issuecomment-197681445
Let me close and try to create a new pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Flink 3579 Improve String concatenation
Posted by ramkrish86 <gi...@git.apache.org>.
Github user ramkrish86 closed the pull request at:
https://github.com/apache/flink/pull/1788
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Flink 3579 Improve String concatenation
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1788#issuecomment-197206933
Hi @ramkrish86, the Table API is currently developed in a separate branch (which will be merged to master soon). Therefore, you have to open a PR against the `tableOnCalcite` branch and not against `master`.
Thanks, Fabian
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Flink 3579 Improve String concatenation
Posted by ramkrish86 <gi...@git.apache.org>.
Github user ramkrish86 commented on the pull request:
https://github.com/apache/flink/pull/1788#issuecomment-197681056
Oops. Just seeing this comment. I was wondering what mistake I was doing. So can I close this pull request and create a new one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---