You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Kristian Waagan (JIRA)" <de...@db.apache.org> on 2006/03/10 17:57:38 UTC

[jira] Created: (DERBY-1097) Add tests for Statement.isClosed()

Add tests for Statement.isClosed()
----------------------------------

         Key: DERBY-1097
         URL: http://issues.apache.org/jira/browse/DERBY-1097
     Project: Derby
        Type: Sub-task
  Components: Test  
    Versions: 10.2.0.0    
 Environment: JDBC4 / JDK 1.6
    Reporter: Kristian Waagan
 Assigned to: Kristian Waagan 


Add tests for Statement.isClosed() (implemented as part of DERBY-953).
The tests are already written, but because of some "confusion" and diverging paths regarding how to get connections when running JUnit tests, they are held back.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (DERBY-1097) Add tests for Statement.isClosed()

Posted by "Kristian Waagan (JIRA)" <de...@db.apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-1097?page=all ]

Kristian Waagan updated DERBY-1097:
-----------------------------------

    Attachment: DERBY-1097-2a.stat
                DERBY-1097-2a.diff

Answering David's comments of 18th of March, and uploading 'DERBY-1097-2a.diff' (patch deprecates previous patches).

Committing sound test code that is known to fail beacause of another bug in Derby must be allowed in my opinion, as long as they are not included in any suites and will be fixed shortly. Also, in this case, the fact that the test code works for embedded is an indication (but not a guarantee) that the test code is sound - the same code is run for DerbyNetClient. The error happens in the one-time setup code in StatementTestSetup.setUp(), but it is now gone because the bug is already fixed.
Finally, I have not submitted a patch for enabling the test, thus it would not cause problems for anyone.

I have removed the exclamation marks in the assertion messages.

I don't understand this comment: "It's a little odd to me that you run an embedded test under the DerbyNetClient framework."
Did you look at the old/initial submission, or have I forgotten to remove some comments?
I agree that what the jdbc4 suite does is odd, but that is not my code. I initially wrote StatementTest so that it could be added to the jdbc4 suite, but was convinced this was not the best idea because of how it is run.
StatementTest itself can be run under embedded or DerbyNetClient. It doesn't run under DerbyNet (JCC), because the driver does not support JDBC4.

A new suite will be created, but I'm not sure what is the best solution yet, so I would like some comments on it.
Should I create a new JDBC4 suite, say 'jdbc40', then add this to derbyall and derbynetclientmats?
All JVMs except JDK 1.6 will be excluded and so will running under DerbyNet be.



> Add tests for Statement.isClosed()
> ----------------------------------
>
>          Key: DERBY-1097
>          URL: http://issues.apache.org/jira/browse/DERBY-1097
>      Project: Derby
>         Type: Sub-task
>   Components: Test
>     Versions: 10.2.0.0
>  Environment: JDBC4 / JDK 1.6
>     Reporter: Kristian Waagan
>     Assignee: Kristian Waagan
>  Attachments: DERBY-1097-2a.diff, DERBY-1097-2a.stat, StatementTest.java, StatementTest.java-v1, StatementTestSetup.java, StatementTestSetup.java-v1
>
> Add tests for Statement.isClosed() (implemented as part of DERBY-953).
> The tests are already written, but because of some "confusion" and diverging paths regarding how to get connections when running JUnit tests, they are held back.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DERBY-1097) Add tests for Statement.isClosed()

Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-1097?page=comments#action_12371364 ] 

David Van Couvering commented on DERBY-1097:
--------------------------------------------

Hi, Kristian.  Sorry to bounce this back, but Rick's latest jdbc40 test suite checkin has thrown a spanner in the works.

I am a little unclear how Rick's checkin impacts your patch here.  Can you investigate and make any necessary/useful changes?  It looks like some of your workaround may be avoided now?

Rick, could you look at this patch and suggest how things might have changed with your rework of the jdbc40 tests?

Thanks,

David



> Add tests for Statement.isClosed()
> ----------------------------------
>
>          Key: DERBY-1097
>          URL: http://issues.apache.org/jira/browse/DERBY-1097
>      Project: Derby
>         Type: Sub-task
>   Components: Test
>     Versions: 10.2.0.0
>  Environment: JDBC4 / JDK 1.6
>     Reporter: Kristian Waagan
>     Assignee: Kristian Waagan
>  Attachments: DERBY-1097-2a.diff, DERBY-1097-2a.stat, DERBY-1097-2b.diff, StatementTest.java, StatementTest.java-v1, StatementTestSetup.java, StatementTestSetup.java-v1
>
> Add tests for Statement.isClosed() (implemented as part of DERBY-953).
> The tests are already written, but because of some "confusion" and diverging paths regarding how to get connections when running JUnit tests, they are held back.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Re: [jira] Commented: (DERBY-1097) Add tests for Statement.isClosed()

Posted by Andreas Korneliussen <An...@Sun.COM>.
Rick Hillegas (JIRA) wrote:
>     [ http://issues.apache.org/jira/browse/DERBY-1097?page=comments#action_12371372 ] 
> 
> Rick Hillegas commented on DERBY-1097:
> --------------------------------------
> 
> I'm afraid I don't know how to wire this test into the jdbc40 suite. I tried wiring StatementTest.junit at the end of the jdbc40 suite but I get the following error under embedded and network:
>

> ********* Diff file jdbc40/jdbc40/StatementTest.diff
> *** Start: StatementTest jdk1.6.0-beta2 jdbc40:jdbc40 2006-03-21 17:27:59 ***
> 0 add
>> java.lang.NoSuchMethodError: main
>> Exception in thread "main" 
> Test Failed.
> *** End:   StatementTest jdk1.6.0-beta2 jdbc40:jdbc40 2006-03-21 17:28:13 ***
>

This error indicates that the test was included as type .java instead of 
type .junit



Andreas


> 
>> Add tests for Statement.isClosed()
>> ----------------------------------
>>
>>          Key: DERBY-1097
>>          URL: http://issues.apache.org/jira/browse/DERBY-1097
>>      Project: Derby
>>         Type: Sub-task
>>   Components: Test
>>     Versions: 10.2.0.0
>>  Environment: JDBC4 / JDK 1.6
>>     Reporter: Kristian Waagan
>>     Assignee: Kristian Waagan
>>  Attachments: DERBY-1097-2a.diff, DERBY-1097-2a.stat, DERBY-1097-2b.diff, StatementTest.java, StatementTest.java-v1, StatementTestSetup.java, StatementTestSetup.java-v1
>>
>> Add tests for Statement.isClosed() (implemented as part of DERBY-953).
>> The tests are already written, but because of some "confusion" and diverging paths regarding how to get connections when running JUnit tests, they are held back.
> 


[jira] Commented: (DERBY-1097) Add tests for Statement.isClosed()

Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-1097?page=comments#action_12371372 ] 

Rick Hillegas commented on DERBY-1097:
--------------------------------------

I'm afraid I don't know how to wire this test into the jdbc40 suite. I tried wiring StatementTest.junit at the end of the jdbc40 suite but I get the following error under embedded and network:

********* Diff file jdbc40/jdbc40/StatementTest.diff
*** Start: StatementTest jdk1.6.0-beta2 jdbc40:jdbc40 2006-03-21 17:27:59 ***
0 add
> java.lang.NoSuchMethodError: main
> Exception in thread "main" 
Test Failed.
*** End:   StatementTest jdk1.6.0-beta2 jdbc40:jdbc40 2006-03-21 17:28:13 ***


> Add tests for Statement.isClosed()
> ----------------------------------
>
>          Key: DERBY-1097
>          URL: http://issues.apache.org/jira/browse/DERBY-1097
>      Project: Derby
>         Type: Sub-task
>   Components: Test
>     Versions: 10.2.0.0
>  Environment: JDBC4 / JDK 1.6
>     Reporter: Kristian Waagan
>     Assignee: Kristian Waagan
>  Attachments: DERBY-1097-2a.diff, DERBY-1097-2a.stat, DERBY-1097-2b.diff, StatementTest.java, StatementTest.java-v1, StatementTestSetup.java, StatementTestSetup.java-v1
>
> Add tests for Statement.isClosed() (implemented as part of DERBY-953).
> The tests are already written, but because of some "confusion" and diverging paths regarding how to get connections when running JUnit tests, they are held back.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (DERBY-1097) Add tests for Statement.isClosed()

Posted by "Kristian Waagan (JIRA)" <de...@db.apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-1097?page=all ]
     
Kristian Waagan closed DERBY-1097:
----------------------------------


Closed, tests added and run under jdbc40 suite.

> Add tests for Statement.isClosed()
> ----------------------------------
>
>          Key: DERBY-1097
>          URL: http://issues.apache.org/jira/browse/DERBY-1097
>      Project: Derby
>         Type: Sub-task
>   Components: Test
>     Versions: 10.2.0.0
>  Environment: JDBC4 / JDK 1.6
>     Reporter: Kristian Waagan
>     Assignee: Kristian Waagan
>  Attachments: DERBY-1097-2a.diff, DERBY-1097-2a.stat, DERBY-1097-2b.diff, StatementTest.java, StatementTest.java-v1, StatementTestSetup.java, StatementTestSetup.java-v1
>
> Add tests for Statement.isClosed() (implemented as part of DERBY-953).
> The tests are already written, but because of some "confusion" and diverging paths regarding how to get connections when running JUnit tests, they are held back.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DERBY-1097) Add tests for Statement.isClosed()

Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-1097?page=comments#action_12371585 ] 

David Van Couvering commented on DERBY-1097:
--------------------------------------------

FYI, when I run this test with the DERBY-953 patch, I don't get this error.

> Add tests for Statement.isClosed()
> ----------------------------------
>
>          Key: DERBY-1097
>          URL: http://issues.apache.org/jira/browse/DERBY-1097
>      Project: Derby
>         Type: Sub-task
>   Components: Test
>     Versions: 10.2.0.0
>  Environment: JDBC4 / JDK 1.6
>     Reporter: Kristian Waagan
>     Assignee: Kristian Waagan
>  Attachments: DERBY-1097-2a.diff, DERBY-1097-2a.stat, DERBY-1097-2b.diff, StatementTest.java, StatementTest.java-v1, StatementTestSetup.java, StatementTestSetup.java-v1
>
> Add tests for Statement.isClosed() (implemented as part of DERBY-953).
> The tests are already written, but because of some "confusion" and diverging paths regarding how to get connections when running JUnit tests, they are held back.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DERBY-1097) Add tests for Statement.isClosed()

Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-1097?page=comments#action_12371481 ] 

David Van Couvering commented on DERBY-1097:
--------------------------------------------

OK, I can get into JIRA again.  I'll add this to the jdbc4 test suite as a junit test, and commit it along with the functionality changes (DERBY-953)

> Add tests for Statement.isClosed()
> ----------------------------------
>
>          Key: DERBY-1097
>          URL: http://issues.apache.org/jira/browse/DERBY-1097
>      Project: Derby
>         Type: Sub-task
>   Components: Test
>     Versions: 10.2.0.0
>  Environment: JDBC4 / JDK 1.6
>     Reporter: Kristian Waagan
>     Assignee: Kristian Waagan
>  Attachments: DERBY-1097-2a.diff, DERBY-1097-2a.stat, DERBY-1097-2b.diff, StatementTest.java, StatementTest.java-v1, StatementTestSetup.java, StatementTestSetup.java-v1
>
> Add tests for Statement.isClosed() (implemented as part of DERBY-953).
> The tests are already written, but because of some "confusion" and diverging paths regarding how to get connections when running JUnit tests, they are held back.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DERBY-1097) Add tests for Statement.isClosed()

Posted by "Andreas Korneliussen (JIRA)" <de...@db.apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-1097?page=comments#action_12371533 ] 

Andreas Korneliussen commented on DERBY-1097:
---------------------------------------------

Rick, I think you need to recompile everything, since you get java.lang.AbstractMethodError. I think there is something wrong with your build or checkout. Clearly, EmbedStatement.isClosed() must be implemented somewhere, either in the class itself or in one of the subclasses. 


> Add tests for Statement.isClosed()
> ----------------------------------
>
>          Key: DERBY-1097
>          URL: http://issues.apache.org/jira/browse/DERBY-1097
>      Project: Derby
>         Type: Sub-task
>   Components: Test
>     Versions: 10.2.0.0
>  Environment: JDBC4 / JDK 1.6
>     Reporter: Kristian Waagan
>     Assignee: Kristian Waagan
>  Attachments: DERBY-1097-2a.diff, DERBY-1097-2a.stat, DERBY-1097-2b.diff, StatementTest.java, StatementTest.java-v1, StatementTestSetup.java, StatementTestSetup.java-v1
>
> Add tests for Statement.isClosed() (implemented as part of DERBY-953).
> The tests are already written, but because of some "confusion" and diverging paths regarding how to get connections when running JUnit tests, they are held back.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DERBY-1097) Add tests for Statement.isClosed()

Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-1097?page=comments#action_12370913 ] 

David Van Couvering commented on DERBY-1097:
--------------------------------------------

Looking at the test source, these look good, although I don't know about having an "!" after every assert string.

It's a little odd to me that you run an embedded test under the DerbyNetClient framework.

Can't we create a new suite that is the subset of jdbc4 tests that run under both the network client and embedded, and then run that subset as a suite under the embedded framework?  This would seem better to me than the way this test is done.

> Add tests for Statement.isClosed()
> ----------------------------------
>
>          Key: DERBY-1097
>          URL: http://issues.apache.org/jira/browse/DERBY-1097
>      Project: Derby
>         Type: Sub-task
>   Components: Test
>     Versions: 10.2.0.0
>  Environment: JDBC4 / JDK 1.6
>     Reporter: Kristian Waagan
>     Assignee: Kristian Waagan
>  Attachments: StatementTest.java, StatementTest.java-v1, StatementTestSetup.java, StatementTestSetup.java-v1
>
> Add tests for Statement.isClosed() (implemented as part of DERBY-953).
> The tests are already written, but because of some "confusion" and diverging paths regarding how to get connections when running JUnit tests, they are held back.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (DERBY-1097) Add tests for Statement.isClosed()

Posted by "Kristian Waagan (JIRA)" <de...@db.apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-1097?page=all ]

Kristian Waagan updated DERBY-1097:
-----------------------------------

    Attachment: DERBY-1097-2b.diff

Updated patch, 'DERBY-1097-2b.diff'. See 'DERBY-1097-2a.stat' svn status.
Previous patch was not the correct patch. It would have been nice to be able to delete attachments now ;)

> Add tests for Statement.isClosed()
> ----------------------------------
>
>          Key: DERBY-1097
>          URL: http://issues.apache.org/jira/browse/DERBY-1097
>      Project: Derby
>         Type: Sub-task
>   Components: Test
>     Versions: 10.2.0.0
>  Environment: JDBC4 / JDK 1.6
>     Reporter: Kristian Waagan
>     Assignee: Kristian Waagan
>  Attachments: DERBY-1097-2a.diff, DERBY-1097-2a.stat, DERBY-1097-2b.diff, StatementTest.java, StatementTest.java-v1, StatementTestSetup.java, StatementTestSetup.java-v1
>
> Add tests for Statement.isClosed() (implemented as part of DERBY-953).
> The tests are already written, but because of some "confusion" and diverging paths regarding how to get connections when running JUnit tests, they are held back.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DERBY-1097) Add tests for Statement.isClosed()

Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-1097?page=comments#action_12371366 ] 

Rick Hillegas commented on DERBY-1097:
--------------------------------------

I think that my rototill doesn't affect Kristian's patch. He has written a JUnit test which uses conventional machinery to get a connection. That is, he did not follow the idiosyncratic pattern used by the other tests and that's why he was reluctant to wire this into the old suite. It should be possible to just wire his test into the jdbc40 suite. In fact, that's the only recommendation I would make. I can take a look at this when I pop off my interrupt stack.

> Add tests for Statement.isClosed()
> ----------------------------------
>
>          Key: DERBY-1097
>          URL: http://issues.apache.org/jira/browse/DERBY-1097
>      Project: Derby
>         Type: Sub-task
>   Components: Test
>     Versions: 10.2.0.0
>  Environment: JDBC4 / JDK 1.6
>     Reporter: Kristian Waagan
>     Assignee: Kristian Waagan
>  Attachments: DERBY-1097-2a.diff, DERBY-1097-2a.stat, DERBY-1097-2b.diff, StatementTest.java, StatementTest.java-v1, StatementTestSetup.java, StatementTestSetup.java-v1
>
> Add tests for Statement.isClosed() (implemented as part of DERBY-953).
> The tests are already written, but because of some "confusion" and diverging paths regarding how to get connections when running JUnit tests, they are held back.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (DERBY-1097) Add tests for Statement.isClosed()

Posted by "Kristian Waagan (JIRA)" <de...@db.apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-1097?page=all ]

Kristian Waagan updated DERBY-1097:
-----------------------------------

    Attachment: StatementTest.java
                StatementTestSetup.java

Updated preliminary tests for Statement.isClosed(). Feedback is appreciated, but the files are *not* ready for commit (awaiting review and need to see where the JUnit infrastructure discussion lands).

> Add tests for Statement.isClosed()
> ----------------------------------
>
>          Key: DERBY-1097
>          URL: http://issues.apache.org/jira/browse/DERBY-1097
>      Project: Derby
>         Type: Sub-task
>   Components: Test
>     Versions: 10.2.0.0
>  Environment: JDBC4 / JDK 1.6
>     Reporter: Kristian Waagan
>     Assignee: Kristian Waagan
>  Attachments: StatementTest.java, StatementTestSetup.java
>
> Add tests for Statement.isClosed() (implemented as part of DERBY-953).
> The tests are already written, but because of some "confusion" and diverging paths regarding how to get connections when running JUnit tests, they are held back.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DERBY-1097) Add tests for Statement.isClosed()

Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-1097?page=comments#action_12370910 ] 

David Van Couvering commented on DERBY-1097:
--------------------------------------------

There is a jdbc4 suite.  You can add any JUnit test to a suite using the .junit extension (e.g. StatementTest.junit).  Does that answer your question, Rick?

I agree with Rick I don't understand your discussion of the test finding another bug.  Did you open a JIRA for the bug?  Do you want us to commit it with the known failure and a master file that includes the failure?  I would rather see the test code commented out, with a note indicating it's waiting on a fix for JIRA id XXXXX.  

You know my opinions on patches that are not in svn diff format :)

> Add tests for Statement.isClosed()
> ----------------------------------
>
>          Key: DERBY-1097
>          URL: http://issues.apache.org/jira/browse/DERBY-1097
>      Project: Derby
>         Type: Sub-task
>   Components: Test
>     Versions: 10.2.0.0
>  Environment: JDBC4 / JDK 1.6
>     Reporter: Kristian Waagan
>     Assignee: Kristian Waagan
>  Attachments: StatementTest.java, StatementTest.java-v1, StatementTestSetup.java, StatementTestSetup.java-v1
>
> Add tests for Statement.isClosed() (implemented as part of DERBY-953).
> The tests are already written, but because of some "confusion" and diverging paths regarding how to get connections when running JUnit tests, they are held back.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (DERBY-1097) Add tests for Statement.isClosed()

Posted by "Kristian Waagan (JIRA)" <de...@db.apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-1097?page=all ]

Kristian Waagan updated DERBY-1097:
-----------------------------------

    Attachment: StatementTest.java-v1
                StatementTestSetup.java-v1

Updated tests to run with the new base JUnit test classes. Had to rename files because I can't delete the old ones; 'StatementTest.java-v1' and 'StatementTestSetup.java-v1'. Tests are not yet added to a suite. They could be added to jdbc4 suite, but then they would only be run under DerbyNetClient, not embedded.

* Tests passed for embedded.
* Tests cannot be run under DerbyNet, because JCC (at least my version) does not support JDBC4 (you'll get an AbstractMethodError).
* Tests fail when run unmodified under DerbyNetClient (see error below). This is because of (another) bug in the exception or stored procedure handling. If offending test code is removed in StatementTestSetup.setUp (lines 61-70), tests pass also under DerbyNetClient.

Tests ready for review/commit.

> There was 1 error:
> 1) org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTestjava.sql.SQLException: DERBY SQL error: SQLCODE: -1, SQLSTATE: XJ009, SQLERRMC: Use of CallableStatement required for stored procedure call or use of output parameters: call SYSIBM.SQLCAMESSAGE(?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)
> Caused by: org.apache.derby.client.am.SqlException: DERBY SQL error: SQLCODE: -1, SQLSTATE: XJ009, SQLERRMC: Use of CallableStatement required for stored procedure call or use of output parameters: call SYSIBM.SQLCAMESSAGE(?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)
>       ... 8 more
> FAILURES!!!
> Tests run: 0,  Failures: 0,  Errors: 1
Test Failed.
*** End:   StatementTest jdk1.6.0-beta2 DerbyNetClient 2006-03-17 14:41:58 ***


> Add tests for Statement.isClosed()
> ----------------------------------
>
>          Key: DERBY-1097
>          URL: http://issues.apache.org/jira/browse/DERBY-1097
>      Project: Derby
>         Type: Sub-task
>   Components: Test
>     Versions: 10.2.0.0
>  Environment: JDBC4 / JDK 1.6
>     Reporter: Kristian Waagan
>     Assignee: Kristian Waagan
>  Attachments: StatementTest.java, StatementTest.java-v1, StatementTestSetup.java, StatementTestSetup.java-v1
>
> Add tests for Statement.isClosed() (implemented as part of DERBY-953).
> The tests are already written, but because of some "confusion" and diverging paths regarding how to get connections when running JUnit tests, they are held back.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DERBY-1097) Add tests for Statement.isClosed()

Posted by "Kristian Waagan (JIRA)" <de...@db.apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-1097?page=comments#action_12371394 ] 

Kristian Waagan commented on DERBY-1097:
----------------------------------------

I tried it in my environment, and it worked by simply adding the line "jdbc4/StatementTest.junit" to the jdbc40.runall file.
If I replace the extension ".junit" with ".java", I get the error you got.

> Add tests for Statement.isClosed()
> ----------------------------------
>
>          Key: DERBY-1097
>          URL: http://issues.apache.org/jira/browse/DERBY-1097
>      Project: Derby
>         Type: Sub-task
>   Components: Test
>     Versions: 10.2.0.0
>  Environment: JDBC4 / JDK 1.6
>     Reporter: Kristian Waagan
>     Assignee: Kristian Waagan
>  Attachments: DERBY-1097-2a.diff, DERBY-1097-2a.stat, DERBY-1097-2b.diff, StatementTest.java, StatementTest.java-v1, StatementTestSetup.java, StatementTestSetup.java-v1
>
> Add tests for Statement.isClosed() (implemented as part of DERBY-953).
> The tests are already written, but because of some "confusion" and diverging paths regarding how to get connections when running JUnit tests, they are held back.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DERBY-1097) Add tests for Statement.isClosed()

Posted by "Andreas Korneliussen (JIRA)" <de...@db.apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-1097?page=comments#action_12371535 ] 

Andreas Korneliussen commented on DERBY-1097:
---------------------------------------------

Actually, I think isClosed() is introduced in JDBC 4, and EmbedStatement is compiled against the rt of jdk 1.3 or jdk1.4. So it is possible to compile Derby without having the isClosed() method in EmbedStatement implemented. So you probably need to download the patch in DERBY-953 to make the test succeed.

> Add tests for Statement.isClosed()
> ----------------------------------
>
>          Key: DERBY-1097
>          URL: http://issues.apache.org/jira/browse/DERBY-1097
>      Project: Derby
>         Type: Sub-task
>   Components: Test
>     Versions: 10.2.0.0
>  Environment: JDBC4 / JDK 1.6
>     Reporter: Kristian Waagan
>     Assignee: Kristian Waagan
>  Attachments: DERBY-1097-2a.diff, DERBY-1097-2a.stat, DERBY-1097-2b.diff, StatementTest.java, StatementTest.java-v1, StatementTestSetup.java, StatementTestSetup.java-v1
>
> Add tests for Statement.isClosed() (implemented as part of DERBY-953).
> The tests are already written, but because of some "confusion" and diverging paths regarding how to get connections when running JUnit tests, they are held back.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Re: [jira] Commented: (DERBY-1097) Add tests for Statement.isClosed()

Posted by "David W. Van Couvering" <Da...@Sun.COM>.
How come you can get to JIRA and I can't?  Hmph.

Anyway, the reason you are getting this is because the functionality 
Statement.isClosed() is not yet implemented (that's the patch I am 
trying to commit once I get access to JIRA).

David

Rick Hillegas (JIRA) wrote:
>     [ http://issues.apache.org/jira/browse/DERBY-1097?page=comments#action_12371474 ] 
> 
> Rick Hillegas commented on DERBY-1097:
> --------------------------------------
> 
> Now when I add jdbc/StatementTest.junit to the end of jdbc40.runall, I get the following diffs in the network and embedded runs:
> 
> *** Start: StatementTest jdk1.6.0-beta2 jdbc40:jdbc40 2006-03-22 13:30:46 ***
> 0 add
> 
>>.E.E.E.E.E
>>There were 5 errors:
>>1) testIsClosedBasic(org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest)java.lang.AbstractMethodError: org.apache.derby.impl.jdbc.EmbedStatement.isClosed()Z
>>2) testIsClosedWithTwoStatementsOnSameConnection(org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest)java.lang.AbstractMethodError: org.apache.derby.impl.jdbc.EmbedStatement.isClosed()Z
>>3) testIsClosedWhenClosingConnection(org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest)java.lang.AbstractMethodError: org.apache.derby.impl.jdbc.EmbedStatement.isClosed()Z
>>4) testIsClosedWhenClosingConnectionInInvalidState(org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest)java.lang.AbstractMethodError: org.apache.derby.impl.jdbc.EmbedStatement.isClosed()Z
>>5) testStatementExecuteAfterConnectionClose(org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest)java.lang.AbstractMethodError: org.apache.derby.impl.jdbc.EmbedStatement.isClosed()Z
>>FAILURES!!!
>>Tests run: 5,  Failures: 0,  Errors: 5
> 
> Test Failed.
> *** End:   StatementTest jdk1.6.0-beta2 jdbc40:jdbc40 2006-03-22 13:31:12 ***
> 
> I see the following output in StatementTest.tmp:
> 
> .E.E.E.E.E
> Time: 7.125
> There were 5 errors:
> 1) testIsClosedBasic(org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest)java.lang.AbstractMethodError: org.apache.derby.impl.jdbc.EmbedStatement.isClosed()Z
> 	at org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest.setUp(StatementTest.java:63)
> 	at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22)
> 	at junit.extensions.TestSetup$1.protect(TestSetup.java:19)
> 	at junit.extensions.TestSetup.run(TestSetup.java:23)
> 2) testIsClosedWithTwoStatementsOnSameConnection(org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest)java.lang.AbstractMethodError: org.apache.derby.impl.jdbc.EmbedStatement.isClosed()Z
> 	at org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest.setUp(StatementTest.java:63)
> 	at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22)
> 	at junit.extensions.TestSetup$1.protect(TestSetup.java:19)
> 	at junit.extensions.TestSetup.run(TestSetup.java:23)
> 3) testIsClosedWhenClosingConnection(org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest)java.lang.AbstractMethodError: org.apache.derby.impl.jdbc.EmbedStatement.isClosed()Z
> 	at org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest.setUp(StatementTest.java:63)
> 	at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22)
> 	at junit.extensions.TestSetup$1.protect(TestSetup.java:19)
> 	at junit.extensions.TestSetup.run(TestSetup.java:23)
> 4) testIsClosedWhenClosingConnectionInInvalidState(org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest)java.lang.AbstractMethodError: org.apache.derby.impl.jdbc.EmbedStatement.isClosed()Z
> 	at org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest.setUp(StatementTest.java:63)
> 	at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22)
> 	at junit.extensions.TestSetup$1.protect(TestSetup.java:19)
> 	at junit.extensions.TestSetup.run(TestSetup.java:23)
> 5) testStatementExecuteAfterConnectionClose(org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest)java.lang.AbstractMethodError: org.apache.derby.impl.jdbc.EmbedStatement.isClosed()Z
> 	at org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest.setUp(StatementTest.java:63)
> 	at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22)
> 	at junit.extensions.TestSetup$1.protect(TestSetup.java:19)
> 	at junit.extensions.TestSetup.run(TestSetup.java:23)
> 
> FAILURES!!!
> Tests run: 5,  Failures: 0,  Errors: 5
> 
> 
> I am at subversion rev 387925.
> 
> 
>>Add tests for Statement.isClosed()
>>----------------------------------
>>
>>         Key: DERBY-1097
>>         URL: http://issues.apache.org/jira/browse/DERBY-1097
>>     Project: Derby
>>        Type: Sub-task
>>  Components: Test
>>    Versions: 10.2.0.0
>> Environment: JDBC4 / JDK 1.6
>>    Reporter: Kristian Waagan
>>    Assignee: Kristian Waagan
>> Attachments: DERBY-1097-2a.diff, DERBY-1097-2a.stat, DERBY-1097-2b.diff, StatementTest.java, StatementTest.java-v1, StatementTestSetup.java, StatementTestSetup.java-v1
>>
>>Add tests for Statement.isClosed() (implemented as part of DERBY-953).
>>The tests are already written, but because of some "confusion" and diverging paths regarding how to get connections when running JUnit tests, they are held back.
> 
> 

[jira] Commented: (DERBY-1097) Add tests for Statement.isClosed()

Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-1097?page=comments#action_12371474 ] 

Rick Hillegas commented on DERBY-1097:
--------------------------------------

Now when I add jdbc/StatementTest.junit to the end of jdbc40.runall, I get the following diffs in the network and embedded runs:

*** Start: StatementTest jdk1.6.0-beta2 jdbc40:jdbc40 2006-03-22 13:30:46 ***
0 add
> .E.E.E.E.E
> There were 5 errors:
> 1) testIsClosedBasic(org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest)java.lang.AbstractMethodError: org.apache.derby.impl.jdbc.EmbedStatement.isClosed()Z
> 2) testIsClosedWithTwoStatementsOnSameConnection(org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest)java.lang.AbstractMethodError: org.apache.derby.impl.jdbc.EmbedStatement.isClosed()Z
> 3) testIsClosedWhenClosingConnection(org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest)java.lang.AbstractMethodError: org.apache.derby.impl.jdbc.EmbedStatement.isClosed()Z
> 4) testIsClosedWhenClosingConnectionInInvalidState(org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest)java.lang.AbstractMethodError: org.apache.derby.impl.jdbc.EmbedStatement.isClosed()Z
> 5) testStatementExecuteAfterConnectionClose(org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest)java.lang.AbstractMethodError: org.apache.derby.impl.jdbc.EmbedStatement.isClosed()Z
> FAILURES!!!
> Tests run: 5,  Failures: 0,  Errors: 5
Test Failed.
*** End:   StatementTest jdk1.6.0-beta2 jdbc40:jdbc40 2006-03-22 13:31:12 ***

I see the following output in StatementTest.tmp:

.E.E.E.E.E
Time: 7.125
There were 5 errors:
1) testIsClosedBasic(org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest)java.lang.AbstractMethodError: org.apache.derby.impl.jdbc.EmbedStatement.isClosed()Z
	at org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest.setUp(StatementTest.java:63)
	at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22)
	at junit.extensions.TestSetup$1.protect(TestSetup.java:19)
	at junit.extensions.TestSetup.run(TestSetup.java:23)
2) testIsClosedWithTwoStatementsOnSameConnection(org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest)java.lang.AbstractMethodError: org.apache.derby.impl.jdbc.EmbedStatement.isClosed()Z
	at org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest.setUp(StatementTest.java:63)
	at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22)
	at junit.extensions.TestSetup$1.protect(TestSetup.java:19)
	at junit.extensions.TestSetup.run(TestSetup.java:23)
3) testIsClosedWhenClosingConnection(org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest)java.lang.AbstractMethodError: org.apache.derby.impl.jdbc.EmbedStatement.isClosed()Z
	at org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest.setUp(StatementTest.java:63)
	at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22)
	at junit.extensions.TestSetup$1.protect(TestSetup.java:19)
	at junit.extensions.TestSetup.run(TestSetup.java:23)
4) testIsClosedWhenClosingConnectionInInvalidState(org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest)java.lang.AbstractMethodError: org.apache.derby.impl.jdbc.EmbedStatement.isClosed()Z
	at org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest.setUp(StatementTest.java:63)
	at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22)
	at junit.extensions.TestSetup$1.protect(TestSetup.java:19)
	at junit.extensions.TestSetup.run(TestSetup.java:23)
5) testStatementExecuteAfterConnectionClose(org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest)java.lang.AbstractMethodError: org.apache.derby.impl.jdbc.EmbedStatement.isClosed()Z
	at org.apache.derbyTesting.functionTests.tests.jdbc4.StatementTest.setUp(StatementTest.java:63)
	at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22)
	at junit.extensions.TestSetup$1.protect(TestSetup.java:19)
	at junit.extensions.TestSetup.run(TestSetup.java:23)

FAILURES!!!
Tests run: 5,  Failures: 0,  Errors: 5


I am at subversion rev 387925.

> Add tests for Statement.isClosed()
> ----------------------------------
>
>          Key: DERBY-1097
>          URL: http://issues.apache.org/jira/browse/DERBY-1097
>      Project: Derby
>         Type: Sub-task
>   Components: Test
>     Versions: 10.2.0.0
>  Environment: JDBC4 / JDK 1.6
>     Reporter: Kristian Waagan
>     Assignee: Kristian Waagan
>  Attachments: DERBY-1097-2a.diff, DERBY-1097-2a.stat, DERBY-1097-2b.diff, StatementTest.java, StatementTest.java-v1, StatementTestSetup.java, StatementTestSetup.java-v1
>
> Add tests for Statement.isClosed() (implemented as part of DERBY-953).
> The tests are already written, but because of some "confusion" and diverging paths regarding how to get connections when running JUnit tests, they are held back.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Reopened: (DERBY-1097) Add tests for Statement.isClosed()

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan reopened DERBY-1097:
------------------------------------


Reopening to set fix version.

> Add tests for Statement.isClosed()
> ----------------------------------
>
>                 Key: DERBY-1097
>                 URL: https://issues.apache.org/jira/browse/DERBY-1097
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>    Affects Versions: 10.2.1.6
>         Environment: JDBC4 / JDK 1.6
>            Reporter: Kristian Waagan
>         Assigned To: Kristian Waagan
>             Fix For: 10.2.1.6
>
>         Attachments: DERBY-1097-2a.diff, DERBY-1097-2a.stat, DERBY-1097-2b.diff, StatementTest.java, StatementTest.java-v1, StatementTestSetup.java, StatementTestSetup.java-v1
>
>
> Add tests for Statement.isClosed() (implemented as part of DERBY-953).
> The tests are already written, but because of some "confusion" and diverging paths regarding how to get connections when running JUnit tests, they are held back.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (DERBY-1097) Add tests for Statement.isClosed()

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan closed DERBY-1097.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 10.2.1.6

> Add tests for Statement.isClosed()
> ----------------------------------
>
>                 Key: DERBY-1097
>                 URL: https://issues.apache.org/jira/browse/DERBY-1097
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>    Affects Versions: 10.2.1.6
>         Environment: JDBC4 / JDK 1.6
>            Reporter: Kristian Waagan
>         Assigned To: Kristian Waagan
>             Fix For: 10.2.1.6
>
>         Attachments: DERBY-1097-2a.diff, DERBY-1097-2a.stat, DERBY-1097-2b.diff, StatementTest.java, StatementTest.java-v1, StatementTestSetup.java, StatementTestSetup.java-v1
>
>
> Add tests for Statement.isClosed() (implemented as part of DERBY-953).
> The tests are already written, but because of some "confusion" and diverging paths regarding how to get connections when running JUnit tests, they are held back.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (DERBY-1097) Add tests for Statement.isClosed()

Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-1097?page=all ]
     
David Van Couvering resolved DERBY-1097:
----------------------------------------

    Resolution: Fixed

Committed revision 388234, along with the checking for DERBY-953.  

> Add tests for Statement.isClosed()
> ----------------------------------
>
>          Key: DERBY-1097
>          URL: http://issues.apache.org/jira/browse/DERBY-1097
>      Project: Derby
>         Type: Sub-task
>   Components: Test
>     Versions: 10.2.0.0
>  Environment: JDBC4 / JDK 1.6
>     Reporter: Kristian Waagan
>     Assignee: Kristian Waagan
>  Attachments: DERBY-1097-2a.diff, DERBY-1097-2a.stat, DERBY-1097-2b.diff, StatementTest.java, StatementTest.java-v1, StatementTestSetup.java, StatementTestSetup.java-v1
>
> Add tests for Statement.isClosed() (implemented as part of DERBY-953).
> The tests are already written, but because of some "confusion" and diverging paths regarding how to get connections when running JUnit tests, they are held back.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DERBY-1097) Add tests for Statement.isClosed()

Posted by "Rick Hillegas (JIRA)" <de...@db.apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-1097?page=comments#action_12370883 ] 

Rick Hillegas commented on DERBY-1097:
--------------------------------------

Hi Kristian,

1) I'm afraid I'm missing some context here. It looks like you have some idea of how these JUnit tests for jdbc4 can be wired into a suite. This will be particularly useful as developers add more JUnit tests for jdbc4. Could you create that suite and provide instructions for how to run it under all the supported environments?

2) I also don't understand the motivation behind checking in a test which fails in an expected environment.

3) When you resubmit the patch, it will really help the reviewer if you package up the whole submission as a diff-style patch. Thanks.

> Add tests for Statement.isClosed()
> ----------------------------------
>
>          Key: DERBY-1097
>          URL: http://issues.apache.org/jira/browse/DERBY-1097
>      Project: Derby
>         Type: Sub-task
>   Components: Test
>     Versions: 10.2.0.0
>  Environment: JDBC4 / JDK 1.6
>     Reporter: Kristian Waagan
>     Assignee: Kristian Waagan
>  Attachments: StatementTest.java, StatementTest.java-v1, StatementTestSetup.java, StatementTestSetup.java-v1
>
> Add tests for Statement.isClosed() (implemented as part of DERBY-953).
> The tests are already written, but because of some "confusion" and diverging paths regarding how to get connections when running JUnit tests, they are held back.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DERBY-1097) Add tests for Statement.isClosed()

Posted by "Kristian Waagan (JIRA)" <de...@db.apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-1097?page=comments#action_12371051 ] 

Kristian Waagan commented on DERBY-1097:
----------------------------------------

Answering Rick's comments of 17th of March.

1) As is already stated, this test can be run from any suite by simply adding it with the .junit extension. I do not want to add it to the existing jdbc4 suite, because this suite is only run under DerbyNetClient (and tests embedded behavior at the same time - ie. it runs tests for two different frameworks under one framework).

Generally, we can follow the existing scheme by adding the names of the tests we want to run in files under functionTests/suites (with the .junit extension, not .java), or we can create a more complex suite() method in a test file. Since the latter solution breaks the way things are currently done, the former is preferred.

I was a bit confused when looking at the suites. I initially thought a suite would be run in all frameworks, except from those explicitly excluded. It seems a suite is only run under the specified framework.
Am I correct in assuming the class must then be added to two different suites?
One for embedded and one for DerbyNetClient? (does run under DerbyNet)

Also, for running only StatementTest, use "RunTest jdbc4/StatementTest.junit". Then add -Dframework to specify framework to run under.

2) I expected the bug to be fixed shortly, and it already is!
Besides, the test is not included in any suite yet, so it would not be run and cause problems for anyone.

3) I will.
New patch will be uploaded after addressing David's comments.

> Add tests for Statement.isClosed()
> ----------------------------------
>
>          Key: DERBY-1097
>          URL: http://issues.apache.org/jira/browse/DERBY-1097
>      Project: Derby
>         Type: Sub-task
>   Components: Test
>     Versions: 10.2.0.0
>  Environment: JDBC4 / JDK 1.6
>     Reporter: Kristian Waagan
>     Assignee: Kristian Waagan
>  Attachments: StatementTest.java, StatementTest.java-v1, StatementTestSetup.java, StatementTestSetup.java-v1
>
> Add tests for Statement.isClosed() (implemented as part of DERBY-953).
> The tests are already written, but because of some "confusion" and diverging paths regarding how to get connections when running JUnit tests, they are held back.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira