You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "rtpsw (via GitHub)" <gi...@apache.org> on 2023/06/04 21:40:45 UTC
[GitHub] [arrow] rtpsw opened a new pull request, #35904: GH-35868: [C++] Occasional TSAN failure on asof-join-node-test
rtpsw opened a new pull request, #35904:
URL: https://github.com/apache/arrow/pull/35904
### Rationale for this change
`AsofJoinNode` may run into a data race when invalidating the key hasher.
### What changes are included in this PR?
The invalidated member of the key hasher is made atomic.
### Are these changes tested?
Yes, by existing testing.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35904: GH-35868: [C++] Occasional TSAN failure on asof-join-node-test
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35904:
URL: https://github.com/apache/arrow/pull/35904#issuecomment-1578096311
Revision: 0ceff4d2da7720820e35c9af33d3e43c44c351d9
Submitted crossbow builds: [ursacomputing/crossbow @ actions-487d9b0cb0](https://github.com/ursacomputing/crossbow/branches/all?query=actions-487d9b0cb0)
|Task|Status|
|----|------|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/5185882294/jobs/9346290634)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #35904: GH-35868: [C++] Occasional TSAN failure on asof-join-node-test
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #35904:
URL: https://github.com/apache/arrow/pull/35904#issuecomment-1578089206
@github-actions crossbow submit test-ubuntu-20.04-cpp-thread-sanitizer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35904: GH-35868: [C++] Occasional TSAN failure on asof-join-node-test
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35904:
URL: https://github.com/apache/arrow/pull/35904#issuecomment-1575744284
:warning: GitHub issue #35868 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou merged pull request #35904: GH-35868: [C++] Occasional TSAN failure on asof-join-node-test
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #35904:
URL: https://github.com/apache/arrow/pull/35904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35904: GH-35868: [C++] Occasional TSAN failure on asof-join-node-test
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35904:
URL: https://github.com/apache/arrow/pull/35904#issuecomment-1578533731
Benchmark runs are scheduled for baseline = e2ae492b63245a8bc6330b10785777ab04659798 and contender = c2536253885eff81f258ccaa3a6834dce0bf192c. c2536253885eff81f258ccaa3a6834dce0bf192c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/1b1cb8b1fa3540fb86acce5d7116e8c5...7f0720594e824dd5a0fb5e9e3e77d2a2/)
[Failed :arrow_down:0.39% :arrow_up:0.03%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/af88293698f141488ed7f6629ccdf0a5...6f9a39a451b34d36830add7d5ca51be3/)
[Failed] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/761ef5266fa348a8890278d54e013022...9a413e044fa94e2c915e866d407edb41/)
[Failed :arrow_down:0.33% :arrow_up:0.06%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/dc2447ce9a5341c6a99dfb1c4f0d3549...7a4607bc7b4d4a2d958e6d714a7b049d/)
Buildkite builds:
[Failed] [`c2536253` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2982)
[Failed] [`c2536253` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/3018)
[Failed] [`c2536253` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2983)
[Failed] [`c2536253` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/3008)
[Failed] [`e2ae492b` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2981)
[Failed] [`e2ae492b` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/3017)
[Failed] [`e2ae492b` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2982)
[Failed] [`e2ae492b` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/3007)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #35904: GH-35868: [C++] Occasional TSAN failure on asof-join-node-test
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #35904:
URL: https://github.com/apache/arrow/pull/35904#issuecomment-1578087760
Adjusted your PR description to add the explanation you gave in https://github.com/apache/arrow/pull/35874/commits/380aa94bd04df435a0be7c6ee05a5e2581008f77#r1218255714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35904: GH-35868: [C++] Occasional TSAN failure on asof-join-node-test
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35904:
URL: https://github.com/apache/arrow/pull/35904#issuecomment-1578087369
:warning: GitHub issue #35868 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rtpsw commented on pull request #35904: GH-35868: [C++] Occasional TSAN failure on asof-join-node-test
Posted by "rtpsw (via GitHub)" <gi...@apache.org>.
rtpsw commented on PR #35904:
URL: https://github.com/apache/arrow/pull/35904#issuecomment-1577510781
cc @pitrou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org