You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2021/01/21 21:42:14 UTC
Review Request 73156: RANGER-3156: RangerResouceTrie.add() and
RangerResourceTrie.delete() do not work correctly for the resources
containing wildcards
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73156/
-----------------------------------------------------------
Review request for ranger, Madhan Neethiraj, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-3156
https://issues.apache.org/jira/browse/RANGER-3156
Repository: ranger
Description
-------
RangerResourceTrie class supports add() and delete() APIs to incrementally update the Trie data structure with a single evaluator. When the evaluator's resource contains wildcards, both APIs leave the Trie tree in an inconsistent state.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceTrie.java 6d784c267
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java e1f09b887
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerPolicyDeltaUtil.java 02694617b
agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngineForDeltas.java PRE-CREATION
agents-common/src/test/resources/policyengine/test_policyengine_hdfs_incremental_delete.json PRE-CREATION
security-admin/src/main/resources/META-INF/jpa_named_queries.xml f6951f6c4
Diff: https://reviews.apache.org/r/73156/diff/1/
Testing
-------
Passes all existing unit tests.
Created unit tests for the fix.
Thanks,
Abhay Kulkarni
Re: Review Request 73156: RANGER-3156: RangerResouceTrie.add() and
RangerResourceTrie.delete() do not work correctly for the resources
containing wildcards
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73156/#review222518
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Jan. 22, 2021, 2:45 p.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73156/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2021, 2:45 p.m.)
>
>
> Review request for ranger, Madhan Neethiraj, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3156
> https://issues.apache.org/jira/browse/RANGER-3156
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RangerResourceTrie class supports add() and delete() APIs to incrementally update the Trie data structure with a single evaluator. When the evaluator's resource contains wildcards, both APIs leave the Trie tree in an inconsistent state.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceTrie.java 6d784c267
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java e1f09b887
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerPolicyDeltaUtil.java 02694617b
> agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngineForDeltas.java PRE-CREATION
> agents-common/src/test/resources/policyengine/test_policyengine_hdfs_incremental_delete.json PRE-CREATION
> security-admin/src/main/resources/META-INF/jpa_named_queries.xml f6951f6c4
>
>
> Diff: https://reviews.apache.org/r/73156/diff/2/
>
>
> Testing
> -------
>
> Passes all existing unit tests.
> Created unit tests for the fix.
>
>
> Thanks,
>
> Abhay Kulkarni
>
>
Re: Review Request 73156: RANGER-3156: RangerResouceTrie.add() and
RangerResourceTrie.delete() do not work correctly for the resources
containing wildcards
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73156/
-----------------------------------------------------------
(Updated Jan. 22, 2021, 2:45 p.m.)
Review request for ranger, Madhan Neethiraj, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Changes
-------
Clean up TrieNode if void to avoid clutter
Bugs: RANGER-3156
https://issues.apache.org/jira/browse/RANGER-3156
Repository: ranger
Description
-------
RangerResourceTrie class supports add() and delete() APIs to incrementally update the Trie data structure with a single evaluator. When the evaluator's resource contains wildcards, both APIs leave the Trie tree in an inconsistent state.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceTrie.java 6d784c267
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java e1f09b887
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerPolicyDeltaUtil.java 02694617b
agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngineForDeltas.java PRE-CREATION
agents-common/src/test/resources/policyengine/test_policyengine_hdfs_incremental_delete.json PRE-CREATION
security-admin/src/main/resources/META-INF/jpa_named_queries.xml f6951f6c4
Diff: https://reviews.apache.org/r/73156/diff/2/
Changes: https://reviews.apache.org/r/73156/diff/1-2/
Testing
-------
Passes all existing unit tests.
Created unit tests for the fix.
Thanks,
Abhay Kulkarni