You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by StefanRRichter <gi...@git.apache.org> on 2016/11/23 13:29:01 UTC
[GitHub] flink pull request #2857: [FLINK-5146] Improved resource cleanup in RocksDB ...
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/2857
[FLINK-5146] Improved resource cleanup in RocksDB keyed state backend
Currently, the resources such as taken snapshots or iterators are not always cleaned up in the RocksDB state backend. In particular, not starting the runnable future will leave taken snapshots unreleased.
This PR improves the behaviour of releasing resources obtained through the RocksDB JNI bridge.
IMPORTANT NOTICE: This PR also upticks the current version of RocksDB to 4.11.2, as I found some instabilities in the old version that could lead to segfaults, in particular at GC time.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StefanRRichter/flink rocks-release-snapshot
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2857.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2857
----
commit b041d87ee97e03e0442f151594e1e5b6f884a0f4
Author: Stefan Richter <s....@data-artisans.com>
Date: 2016-11-12T20:13:28Z
Improved resource cleanup
commit fc032f29d18f662d56a362a8198892cc9961ea72
Author: Stefan Richter <s....@data-artisans.com>
Date: 2016-11-12T22:26:48Z
Unit Tests
commit 97dfc6fc5c417415d344b7f8ce443eebebdddda4
Author: Stefan Richter <s....@data-artisans.com>
Date: 2016-11-13T04:04:03Z
Uptick rocks version
commit 4a988d55641a6971301c69b7b9ddf5b673b1c1c4
Author: Stefan Richter <s....@data-artisans.com>
Date: 2016-11-13T05:04:20Z
testing something
commit 90a90eb121f4a187fe8aaf909388a0c470767896
Author: Stefan Richter <s....@data-artisans.com>
Date: 2016-11-13T14:22:14Z
ownership transfer
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2857: [FLINK-5146] Improved resource cleanup in RocksDB keyed s...
Posted by StefanRRichter <gi...@git.apache.org>.
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/2857
This was a preliminary PR, so that people can already take a look. However, I think besides one sleep in a test, the added value is already enough to have this in. Leftover todos can go to a followup PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2857: [FLINK-5146] Improved resource cleanup in RocksDB keyed s...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2857
Thanks for your work: \U0001f44d
I merged it, could you please close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2857: [FLINK-5146] Improved resource cleanup in RocksDB keyed s...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2857
Overall, the changes and the tests look very good. There are some `TODO`s left in the code, what about those?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2857: [FLINK-5146] Improved resource cleanup in RocksDB keyed s...
Posted by StefanRRichter <gi...@git.apache.org>.
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/2857
Thanks for the reviews and merging, @aljoscha @tillrohrmann . Closing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2857: [FLINK-5146] Improved resource cleanup in RocksDB ...
Posted by StefanRRichter <gi...@git.apache.org>.
Github user StefanRRichter closed the pull request at:
https://github.com/apache/flink/pull/2857
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2857: [FLINK-5146] Improved resource cleanup in RocksDB keyed s...
Posted by StefanRRichter <gi...@git.apache.org>.
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/2857
I introduced the planned change to the test. You could take another look if you want :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---