You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/17 20:54:18 UTC

[GitHub] [pulsar] merlimat opened a new pull request #14359: Fixed missing new line at the end of proxy.conf

merlimat opened a new pull request #14359:
URL: https://github.com/apache/pulsar/pull/14359


   ### Motivation
   
   The `proxy.conf` is missing a new line at the end of the file and that causes issues when adding custom variables through the `apply-from-env.py` script. 
   
    1. Add new line
    2. Make the script to always include a new line to avoid problems in future


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #14359: Fixed missing new line at the end of proxy.conf

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #14359:
URL: https://github.com/apache/pulsar/pull/14359


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #14359: Fixed missing new line at the end of proxy.conf

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14359:
URL: https://github.com/apache/pulsar/pull/14359#issuecomment-1043428333


   @merlimat:Thanks for your contribution. For this PR, do we need to update docs?
   (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall commented on pull request #14359: Fixed missing new line at the end of proxy.conf

Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #14359:
URL: https://github.com/apache/pulsar/pull/14359#issuecomment-1043616557


   Retriggered timed out check


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org