[jira] [Commented] (ARTEMIS-2815) Null pointer exception on queue update

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-2815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142737#comment-17142737 ] 

ASF subversion and git services commented on ARTEMIS-2815:
----------------------------------------------------------

Commit 3e394b45e92a012b2d060ffae37918a840ce0dd2 in activemq-artemis's branch refs/heads/master from Havret
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=3e394b4 ]

ARTEMIS-2815: Fix null pointer exception on attempt to update queue without filter


> Null pointer exception on queue update
> --------------------------------------
>
>                 Key: ARTEMIS-2815
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2815
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.13.0
>            Reporter: Krzysztof Porębski
>            Assignee: Krzysztof Porębski
>            Priority: Major
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> Null pointer exception is thrown on the attempt to update a queue created without a filter. 
> The problem is with getQueueConfiguration method in QueueImpl class. There is no check if filter is null before getFilterString is invoked. 
> {code:java}
> @Override
> public QueueConfiguration getQueueConfiguration() {
>    return new QueueConfiguration(name)
>       .setAddress(address)
>       .setId(id)
>       .setRoutingType(routingType)
>       .setFilterString(filter.getFilterString())
>       .setDurable(isDurable())
>       .setUser(user)
>       .setMaxConsumers(maxConsumers)
>       .setExclusive(exclusive)
>       .setGroupRebalance(groupRebalance)
>       .setGroupBuckets(groupBuckets)
>       .setGroupFirstKey(groupFirstKey)
>       .setLastValue(false)
>       .setLastValue(null)
>       .setNonDestructive(nonDestructive)
>       .setPurgeOnNoConsumers(purgeOnNoConsumers)
>       .setConsumersBeforeDispatch(consumersBeforeDispatch)
>       .setDelayBeforeDispatch(delayBeforeDispatch)
>       .setAutoDelete(autoDelete)
>       .setAutoDeleteDelay(autoDeleteDelay)
>       .setAutoDeleteMessageCount(autoDeleteMessageCount)
>       .setRingSize(ringSize)
>       .setConfigurationManaged(configurationManaged)
>       .setTemporary(temporary)
>       .setInternal(internalQueue)
>       .setTransient(refCountForConsumers instanceof TransientQueueManagerImpl)
>       .setAutoCreated(autoCreated);
> }{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)