You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2017/08/01 22:13:49 UTC
[GitHub] storm pull request #2253: Remove CHANGELOG.md and update DEVELOPER.md to ref...
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/2253
Remove CHANGELOG.md and update DEVELOPER.md to reflect the change
This is for master branch, and I'll proceed this for all other version lines without additional pull requests: 1.x-branch, 1.1.x-branch, 1.0.x-branch, 0.10.x-branch, 0.9.x-branch.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm remove-changelog-master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2253.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2253
----
commit 59f0f1872c691446c6474ea92105880796b3d4e2
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2017-08-01T22:09:46Z
Remove CHANGELOG.md and update DEVELOPER.md to reflect the change
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2253: Remove CHANGELOG.md and update DEVELOPER.md to reflect th...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2253
This looks good. It removes that changelog and updates the docs. But I want to be sure that we have a script for doing the changelog on a release before we actually remove the changelog. Otherwise we are stuck and cannot do a release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2253: Remove CHANGELOG.md and update DEVELOPER.md to reflect th...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2253
I'm just in favor of #2250, and once we have at least one way to handle the changelog in release, I'd like to get this not too late. The discussion was staled once and it was about to be stale again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2253: Remove CHANGELOG.md and update DEVELOPER.md to ref...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2253
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2253: Remove CHANGELOG.md and update DEVELOPER.md to reflect th...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2253
Should we do this before we have the other solution to generating the change log in place?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2253: Remove CHANGELOG.md and update DEVELOPER.md to ref...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2253#discussion_r130747633
--- Diff: DEVELOPER.md ---
@@ -214,14 +214,9 @@ To pull in a merge request you should generally follow the command line instruct
$ git pull <remote_repo_url> <remote_branch>
You can use `./dev-tools/storm-merge.py <pull-number>` to produce the above command most of the time.
-4. Assuming that the pull request merges without any conflicts:
- Update the top-level `CHANGELOG.md`, and add in the JIRA ticket number (example: `STORM-1234`) and ticket
- description to the change log. Make sure that you place the JIRA ticket number in the commit comments where
- applicable.
+4. Run any sanity tests that you think are needed.
--- End diff --
Nit: I think it still makes sense to encourage placing the ticket number in the commit message
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2253: Remove CHANGELOG.md and update DEVELOPER.md to ref...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2253#discussion_r130748562
--- Diff: DEVELOPER.md ---
@@ -214,14 +214,9 @@ To pull in a merge request you should generally follow the command line instruct
$ git pull <remote_repo_url> <remote_branch>
You can use `./dev-tools/storm-merge.py <pull-number>` to produce the above command most of the time.
-4. Assuming that the pull request merges without any conflicts:
- Update the top-level `CHANGELOG.md`, and add in the JIRA ticket number (example: `STORM-1234`) and ticket
- description to the change log. Make sure that you place the JIRA ticket number in the commit comments where
- applicable.
+4. Run any sanity tests that you think are needed.
--- End diff --
The commit message refers to the commit on committing change on CHANGELOG.
If we would want to encourage contributors to place ticket number in the commit, it should be placed on `Create a pull request`. If you mean placing the ticket number on merge commit, we can describe it to 3.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2253: Remove CHANGELOG.md and update DEVELOPER.md to ref...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2253#discussion_r130801135
--- Diff: DEVELOPER.md ---
@@ -214,14 +214,9 @@ To pull in a merge request you should generally follow the command line instruct
$ git pull <remote_repo_url> <remote_branch>
You can use `./dev-tools/storm-merge.py <pull-number>` to produce the above command most of the time.
-4. Assuming that the pull request merges without any conflicts:
- Update the top-level `CHANGELOG.md`, and add in the JIRA ticket number (example: `STORM-1234`) and ticket
- description to the change log. Make sure that you place the JIRA ticket number in the commit comments where
- applicable.
+4. Run any sanity tests that you think are needed.
--- End diff --
Right, that makes sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2253: Remove CHANGELOG.md and update DEVELOPER.md to reflect th...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2253
For got to say that I am +1 once we have that script, or at least enough progress on it to feel good that it is going to happen.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---