[GitHub] [incubator-superset] graceguo-supercat commented on pull request #10834: fix: dashboard edit/save errors

[GitBox <gi...@apache.org>]

graceguo-supercat commented on pull request #10834:
URL: https://github.com/apache/incubator-superset/pull/10834#issuecomment-707508315


   @eschutho and @mistercrunch Thanks for the work, but this save flow really confused me. See how `Set auto-refresh frequency`, `Set filter mapping` etc works, 
   - when user clicks `Save` button in the modal, it is only close Modal but not changes are not sent to server-side db
   - when user clicks `Save` button on dashboard header, the changes are sent to server-side and saved into dashboards table.
   
   But this `Edit dashboard properties` flow, saved changes twice:
   - when user clicks `Save` button in the modal, it saved changes by calling `/api/v1`
   - when user clicks `Save` button on dashboard header, it saved changes by calling `/save_dashboard/`
   Why does it have to save twice and calls different API? 
   
   I think we should have single API do `save dashboard metadata` job, and all the items in the edit dropdown list should behave the same.
   
    


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org