You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/27 18:29:38 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28053:
[SPARK-29153][CORE]Add ability to merge resource profiles within a stage
with Stage Level Scheduling
dongjoon-hyun commented on a change in pull request #28053: [SPARK-29153][CORE]Add ability to merge resource profiles within a stage with Stage Level Scheduling
URL: https://github.com/apache/spark/pull/28053#discussion_r399462804
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -1814,4 +1814,8 @@ package object config {
.bytesConf(ByteUnit.BYTE)
.createOptional
+ private[spark] val RESOURCE_PROFILE_MERGE_CONFLICTS =
+ ConfigBuilder("spark.scheduler.resourceProfile.mergeConflicts")
+ .booleanConf
Review comment:
Hi, @tgravescs .
Could you add `.doc` and `.version` like the other cons?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org