You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Andrey Mashenkov (Jira)" <ji...@apache.org> on 2021/09/03 09:31:00 UTC
[jira] [Commented] (IGNITE-15370) [Ignite 3] Add style check to the
build lifecycle
[ https://issues.apache.org/jira/browse/IGNITE-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409399#comment-17409399 ]
Andrey Mashenkov commented on IGNITE-15370:
-------------------------------------------
[~vveider], PR looks good.
Maybe, maven.all-checks.skip could also disable Errorprone plugin checks as well? WDYT?
Errorprone has next options: {{-XepDisableAllChecks}} and {{-XepAllErrorsAsWarnings}}. I guess the first one might be more performant.
> [Ignite 3] Add style check to the build lifecycle
> -------------------------------------------------
>
> Key: IGNITE-15370
> URL: https://issues.apache.org/jira/browse/IGNITE-15370
> Project: Ignite
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.0.0-alpha2
> Reporter: Valentin Kulichenko
> Assignee: Petr Ivanov
> Priority: Major
> Labels: ignite-3
> Fix For: 3.0.0-alpha3
>
> Time Spent: 14h
> Remaining Estimate: 0h
>
> Currently, the style checker plugin can only be invoked separately. We should add it to the {{compile}} phase of the build.
> Ideally, it should check all the source code, provide a report with all the errors in case there are any, and fail the build right away.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)