You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/01/02 01:43:20 UTC

[GitHub] [incubator-gobblin] abti commented on a change in pull request #3187: [GOBBLIN-1348] Uses own logic for generating tags instead of the docker meta action

abti commented on a change in pull request #3187:
URL: https://github.com/apache/incubator-gobblin/pull/3187#discussion_r550829755



##########
File path: .github/workflows/docker_build_publish.yaml
##########
@@ -21,44 +21,60 @@ on:
     # Publish only on `master`
     branches:
       - master
-
+  pull_request:

Review comment:
       If I understand this correctly, it will trigger the build and push at each pull request creation rather than when a commit is pushed? That would be quite a few docker images with unreviewed code?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org