[GitHub] zeppelin issue #1589: [Zeppelin-1611] - Support PAM (System User) Authentica...

[bzz <gi...@git.apache.org>]

Github user bzz commented on the issue:

    https://github.com/apache/zeppelin/pull/1589
  
    Thank you for contribution!
    
    There are few things need to be taken care here:
     1. make sure the code adhere [project styleguide](https://zeppelin.apache.org/contribution/contributions.html#code-convention) - i.e whildcard imports in Java are discouraged, etc
     2. make sure that licences for all new runtime dependencies [are compatible](https://www.apache.org/legal/resolved#category-a), and were added added to `./zeppelin-distribution/src/bin_license/LICENSE` 
     3. AFAIK right now new tests will not be run on TravisC infrastructure as they require some env vars to be set, but no modifications to [.travis.yml](https://github.com/apache/zeppelin/blob/master/.travis.yml). Do you think it's worth adding them to one CI profile? 
     4. In PR description 
    
      > Does this needs documentation? Yes
    
      Do you plan to provide documentation at `./docs` in this PR as well? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---