[GitHub] [incubator-mxnet] josephevans commented on a change in pull request #17808: [WIP] Windows dev environment configuration, update install instructions from source in the docs

[GitBox <gi...@apache.org>]

josephevans commented on a change in pull request #17808: [WIP] Windows dev environment configuration, update install instructions from source in the docs
URL: https://github.com/apache/incubator-mxnet/pull/17808#discussion_r401357878
 
 

 ##########
 File path: ci/build_windows.py
 ##########
 @@ -193,14 +238,19 @@ def windows_package(args):
         for dll in dlls:
             logging.info("packing dll: %s", dll)
             shutil.copy(dll, pkgdir_lib)
+
+        if pkgdir_lib.find('gpu') != -1:
+            add_path("C:\\jenkins_slave\\workspace\\ut-python-gpu\\windows_package\\lib")
 
 Review comment:
   Updating the path should be done in the testing phase - in ci/windows/test_py3_gpu.ps1 so the tests can find all the DLLs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services