You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/09/15 19:46:17 UTC
[GitHub] [nifi] alopresto opened a new pull request #4533: NIFI-7804 Split nifi-security-utils into sub-module for nifi-security…
alopresto opened a new pull request #4533:
URL: https://github.com/apache/nifi/pull/4533
…-utils-api (no external dependencies).
Separated interface and implementation of TlsConfiguration.
Reabsorbed nifi-security-xml-config into nifi-security-utils.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
_Fixes the conflicting dependency issue when multiple versions of a processor are present._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [x] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] alopresto commented on pull request #4533: NIFI-7804 Split nifi-security-utils into sub-module for nifi-security…
Posted by GitBox <gi...@apache.org>.
alopresto commented on pull request #4533:
URL: https://github.com/apache/nifi/pull/4533#issuecomment-693545256
Had a very weird situation with my IDE where a single line of the fix was not committed (silently), and so what I had locally didn't match what was pushed. Made the change outside of the IDE; as soon as the GHA are done, we should be good to merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende commented on pull request #4533: NIFI-7804 Split nifi-security-utils into sub-module for nifi-security…
Posted by GitBox <gi...@apache.org>.
bbende commented on pull request #4533:
URL: https://github.com/apache/nifi/pull/4533#issuecomment-694361579
+1 ran full build of this, verified dependency locations, verified running older 1.8.0 NARs, and verified PropertiesFileLookupService works, going to squash and merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] alopresto commented on pull request #4533: NIFI-7804 Split nifi-security-utils into sub-module for nifi-security…
Posted by GitBox <gi...@apache.org>.
alopresto commented on pull request #4533:
URL: https://github.com/apache/nifi/pull/4533#issuecomment-692941363
Did a full build on Java 11 with contrib-check and all tests passing.
```
# Verified nifi-standard-services-1.13.0-nar does not contain nifi-security-utils-1.13.0-SNAPSHOT.jar but _does_ include nifi-security-utils-api-1.13.0-SNAPSHOT.jar
..13.0-SNAPSHOT NIFI-7804 ●✚ jar tvf lib/nifi-standard-services-api-nar-1.13.0-SNAPSHOT.nar | \grep --color=auto --exclude-dir=.bzr --exclude-dir=CVS --exclude-dir=.git --exclude-dir=.hg --exclude-dir=.svn --exclude-dir=.idea --exclude-dir=.tox ".jar"
14265 Tue Sep 15 11:21:18 PDT 2020 META-INF/bundled-dependencies/nifi-hbase-client-service-api-1.13.0-SNAPSHOT.jar
10571 Tue Sep 15 11:21:18 PDT 2020 META-INF/bundled-dependencies/nifi-dbcp-service-api-1.13.0-SNAPSHOT.jar
12431 Tue Sep 15 11:21:18 PDT 2020 META-INF/bundled-dependencies/nifi-proxy-configuration-api-1.13.0-SNAPSHOT.jar
10186 Tue Sep 15 11:21:18 PDT 2020 META-INF/bundled-dependencies/nifi-ssl-context-service-api-1.13.0-SNAPSHOT.jar
255502 Tue Sep 15 11:21:18 PDT 2020 META-INF/bundled-dependencies/jaxb-core-2.3.0.jar
7889 Tue Sep 15 11:21:18 PDT 2020 META-INF/bundled-dependencies/nifi-load-distribution-service-api-1.13.0-SNAPSHOT.jar
8666 Tue Sep 15 11:21:18 PDT 2020 META-INF/bundled-dependencies/nifi-schema-registry-service-api-1.13.0-SNAPSHOT.jar
7462 Tue Sep 15 11:21:18 PDT 2020 META-INF/bundled-dependencies/nifi-http-context-map-api-1.13.0-SNAPSHOT.jar
9378 Tue Sep 15 11:21:18 PDT 2020 META-INF/bundled-dependencies/nifi-record-serialization-service-api-1.13.0-SNAPSHOT.jar
963660 Tue Sep 15 11:21:18 PDT 2020 META-INF/bundled-dependencies/jaxb-impl-2.3.0.jar
125632 Tue Sep 15 11:21:18 PDT 2020 META-INF/bundled-dependencies/jaxb-api-2.3.0.jar
12925 Tue Sep 15 11:21:18 PDT 2020 META-INF/bundled-dependencies/nifi-security-utils-api-1.13.0-SNAPSHOT.jar
9148 Tue Sep 15 11:21:18 PDT 2020 META-INF/bundled-dependencies/nifi-lookup-service-api-1.13.0-SNAPSHOT.jar
84302 Tue Sep 15 11:21:18 PDT 2020 META-INF/bundled-dependencies/nifi-record-1.13.0-SNAPSHOT.jar
7495 Tue Sep 15 11:21:18 PDT 2020 META-INF/bundled-dependencies/nifi-kerberos-credentials-service-api-1.13.0-SNAPSHOT.jar
14048 Tue Sep 15 11:21:18 PDT 2020 META-INF/bundled-dependencies/nifi-distributed-cache-client-service-api-1.13.0-SNAPSHOT.jar
12067 Tue Sep 15 11:21:18 PDT 2020 META-INF/bundled-dependencies/nifi-rules-engine-service-api-1.13.0-SNAPSHOT.jar
178884 Tue Sep 15 11:21:18 PDT 2020 META-INF/bundled-dependencies/nifi-utils-1.13.0-SNAPSHOT.jar
9945 Tue Sep 15 11:21:18 PDT 2020 META-INF/bundled-dependencies/nifi-oauth2-provider-api-1.13.0-SNAPSHOT.jar
8795 Tue Sep 15 11:21:18 PDT 2020 META-INF/bundled-dependencies/nifi-record-sink-api-1.13.0-SNAPSHOT.jar
```
Compiled the 1.9.2 `nifi-standard-nar` and copied into the `lib/` and ran a flow with both `InvokeHTTP` processors (pointing to the same `StandardSSLContextService`). No errors.
[flow_20200915-124119_NIFI-7804-ssl-v2.xml.gz](https://github.com/apache/nifi/files/5227347/flow_20200915-124119_NIFI-7804-ssl-v2.xml.gz)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] alopresto commented on a change in pull request #4533: NIFI-7804 Split nifi-security-utils into sub-module for nifi-security…
Posted by GitBox <gi...@apache.org>.
alopresto commented on a change in pull request #4533:
URL: https://github.com/apache/nifi/pull/4533#discussion_r489080006
##########
File path: nifi-commons/nifi-security-utils-api/pom.xml
##########
@@ -0,0 +1,41 @@
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+ -->
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-commons</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </parent>
+ <artifactId>nifi-security-utils-api</artifactId>
+ <description>
+ This nifi-security-utils-api module holds reusable code necessary for security
+ across the project. This module is included in a number of api modules and must
+ have no external dependencies.
+ </description>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-properties</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ <scope>provided</scope>
+ </dependency>
Review comment:
You're probably right; I think it got added automatically when I was moving things around and isn't necessary. Once the Java 8 build finishes, I'll remove it and re-build the module to double check. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende commented on a change in pull request #4533: NIFI-7804 Split nifi-security-utils into sub-module for nifi-security…
Posted by GitBox <gi...@apache.org>.
bbende commented on a change in pull request #4533:
URL: https://github.com/apache/nifi/pull/4533#discussion_r488948717
##########
File path: nifi-commons/nifi-security-utils-api/pom.xml
##########
@@ -0,0 +1,41 @@
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+ -->
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-commons</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ </parent>
+ <artifactId>nifi-security-utils-api</artifactId>
+ <description>
+ This nifi-security-utils-api module holds reusable code necessary for security
+ across the project. This module is included in a number of api modules and must
+ have no external dependencies.
+ </description>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-properties</artifactId>
+ <version>1.13.0-SNAPSHOT</version>
+ <scope>provided</scope>
+ </dependency>
Review comment:
Should we remove this dependency since there isn't any code in the api module that uses NiFiProperties?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende merged pull request #4533: NIFI-7804 Split nifi-security-utils into sub-module for nifi-security…
Posted by GitBox <gi...@apache.org>.
bbende merged pull request #4533:
URL: https://github.com/apache/nifi/pull/4533
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org