You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Tim Ellison <t....@gmail.com> on 2006/03/29 13:24:39 UTC
Re: [jira] Created: (HARMONY-239) [classlib][luni] Java 5 enhancements
for java.lang.Float
Nathan, I have failing tests after applying this patch, notably in
LUNI tests
AssertionFailedError: Floattest0 at
tests.api.java.lang.FloatTest.test_valueOfLjava_lang_String(FloatTest.java:579)
and
MATH tests
BigDecimalConvertTest#testFloatValuePlusZero()
Please take a look if you have time, otherwise I'll look at it later.
Regards,
Tim
Nathan Beyer (JIRA) wrote:
> [classlib][luni] Java 5 enhancements for java.lang.Float
> --------------------------------------------------------
>
> Key: HARMONY-239
> URL: http://issues.apache.org/jira/browse/HARMONY-239
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Nathan Beyer
>
>
> Patch for Java 5 enhancements to java.lang.Float.
>
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.
RE: [jira] Created: (HARMONY-239) [classlib][luni] Java 5 enhancements for java.lang.Float
Posted by Nathan Beyer <nb...@kc.rr.com>.
There was a problem in the simple caching I put in the class for the valueOf
method. It wasn't discerning between - and + 0.0. I've removed the caching
piece altogether and attached a new diff. Caching of Float and Double
instances probably isn't necessary anyway, but it can always be added later.
This same problem will afflict my post for the Double class enhancements.
Let me know if you want me to post another diff for that as well.
-Nathan
-----Original Message-----
From: Tim Ellison [mailto:t.p.ellison@gmail.com]
Sent: Wednesday, March 29, 2006 5:25 AM
To: harmony-dev@incubator.apache.org
Subject: Re: [jira] Created: (HARMONY-239) [classlib][luni] Java 5
enhancements for java.lang.Float
Nathan, I have failing tests after applying this patch, notably in
LUNI tests
AssertionFailedError: Floattest0 at
tests.api.java.lang.FloatTest.test_valueOfLjava_lang_String(FloatTest.java:5
79)
and
MATH tests
BigDecimalConvertTest#testFloatValuePlusZero()
Please take a look if you have time, otherwise I'll look at it later.
Regards,
Tim
Nathan Beyer (JIRA) wrote:
> [classlib][luni] Java 5 enhancements for java.lang.Float
> --------------------------------------------------------
>
> Key: HARMONY-239
> URL: http://issues.apache.org/jira/browse/HARMONY-239
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Nathan Beyer
>
>
> Patch for Java 5 enhancements to java.lang.Float.
>
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.