You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/06/01 23:20:12 UTC
[GitHub] [incubator-gobblin] sv2000 opened a new pull request #3020: GOBBLIN-1175: Provide an option to all GobblinYarnAppLauncher to detach from Yarn application
sv2000 opened a new pull request #3020:
URL: https://github.com/apache/incubator-gobblin/pull/3020
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1175
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
This enhancement will allow the Gobblin-on-Yarn app launcher to be killed without killing the Gobblin-on-Yarn cluster. For instance, in the case of Azkaban based app launcher, this feature allows Azkaban executors to be restarted (e.g. on deployments) without impacting the Gobblin-on-Yarn application.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-commenter commented on pull request #3020: GOBBLIN-1175: Provide an option to all GobblinYarnAppLauncher to detach from Yarn application
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #3020:
URL: https://github.com/apache/incubator-gobblin/pull/3020#issuecomment-637188284
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@72fc54f`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `12.50%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3020 +/- ##
=========================================
Coverage ? 45.71%
Complexity ? 9285
=========================================
Files ? 1951
Lines ? 74204
Branches ? 8207
=========================================
Hits ? 33921
Misses ? 37111
Partials ? 3172
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...gobblin/azkaban/AzkabanGobblinYarnAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tYXprYWJhbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9hemthYmFuL0F6a2FiYW5Hb2JibGluWWFybkFwcExhdW5jaGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...che/gobblin/yarn/GobblinYarnConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5Db25maWd1cmF0aW9uS2V5cy5qYXZh) | `66.66% <ø> (ø)` | `1.00 <0.00> (?)` | |
| [...rg/apache/gobblin/yarn/GobblinYarnAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5BcHBMYXVuY2hlci5qYXZh) | `24.24% <23.07%> (ø)` | `12.00 <0.00> (?)` | |
| [...ache/gobblin/broker/SharedResourcesBrokerImpl.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2Jyb2tlci9TaGFyZWRSZXNvdXJjZXNCcm9rZXJJbXBsLmphdmE=) | `76.92% <0.00%> (ø)` | `20.00% <0.00%> (?%)` | |
| [.../org/apache/gobblin/metastore/MysqlStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL015c3FsU3RhdGVTdG9yZS5qYXZh) | `8.19% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [...apache/gobblin/metrics/GobblinMetricsRegistry.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3MvR29iYmxpbk1ldHJpY3NSZWdpc3RyeS5qYXZh) | `27.58% <0.00%> (ø)` | `6.00% <0.00%> (?%)` | |
| [...ain/java/org/apache/gobblin/time/TimeIterator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGltZS9UaW1lSXRlcmF0b3IuamF2YQ==) | `73.07% <0.00%> (ø)` | `12.00% <0.00%> (?%)` | |
| [...ics/reporter/RecursiveScheduledMetricReporter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci9SZWN1cnNpdmVTY2hlZHVsZWRNZXRyaWNSZXBvcnRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...org/apache/gobblin/metrics/ServiceMetricNames.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3MvU2VydmljZU1ldHJpY05hbWVzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...retention/profile/MultiCleanableDatasetFinder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9wcm9maWxlL011bHRpQ2xlYW5hYmxlRGF0YXNldEZpbmRlci5qYXZh) | `87.50% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
| ... and [1944 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=footer). Last update [72fc54f...0d5548f](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-commenter edited a comment on pull request #3020: GOBBLIN-1175: Provide an option to all GobblinYarnAppLauncher to detach from Yarn application
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3020:
URL: https://github.com/apache/incubator-gobblin/pull/3020#issuecomment-637188284
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=h1) Report
> Merging [#3020](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/4325920dc72b82d2a96e2ba52ff0363d6f8575b4&el=desc) will **decrease** coverage by `0.19%`.
> The diff coverage is `12.00%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3020 +/- ##
============================================
- Coverage 45.71% 45.51% -0.20%
+ Complexity 9282 9254 -28
============================================
Files 1951 1951
Lines 74195 74592 +397
Branches 8208 8318 +110
============================================
+ Hits 33915 33949 +34
- Misses 37108 37467 +359
- Partials 3172 3176 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...gobblin/azkaban/AzkabanGobblinYarnAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tYXprYWJhbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9hemthYmFuL0F6a2FiYW5Hb2JibGluWWFybkFwcExhdW5jaGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...che/gobblin/yarn/GobblinYarnConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5Db25maWd1cmF0aW9uS2V5cy5qYXZh) | `66.66% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rg/apache/gobblin/yarn/GobblinYarnAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5BcHBMYXVuY2hlci5qYXZh) | `24.24% <21.42%> (+0.28%)` | `12.00 <0.00> (ø)` | |
| [.../apache/gobblin/service/modules/flowgraph/Dag.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93Z3JhcGgvRGFnLmphdmE=) | `60.46% <0.00%> (-33.88%)` | `29.00% <0.00%> (-9.00%)` | |
| [...service/modules/orchestration/DagManagerUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0RhZ01hbmFnZXJVdGlscy5qYXZh) | `55.07% <0.00%> (-29.99%)` | `22.00% <0.00%> (-17.00%)` | |
| [.../org/apache/gobblin/metrics/event/TimingEvent.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9ldmVudC9UaW1pbmdFdmVudC5qYXZh) | `48.61% <0.00%> (-21.39%)` | `7.00% <0.00%> (-8.00%)` | |
| [...blin/service/modules/orchestration/DagManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0RhZ01hbmFnZXIuamF2YQ==) | `56.16% <0.00%> (-15.08%)` | `13.00% <0.00%> (ø%)` | |
| [...in/service/modules/orchestration/Orchestrator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL09yY2hlc3RyYXRvci5qYXZh) | `38.93% <0.00%> (-10.78%)` | `13.00% <0.00%> (ø%)` | |
| [...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=) | `70.00% <0.00%> (-2.23%)` | `13.00% <0.00%> (ø%)` | |
| [.../service/monitoring/KafkaAvroJobStatusMonitor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9LYWZrYUF2cm9Kb2JTdGF0dXNNb25pdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [6 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=footer). Last update [4325920...15dbd33](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] sv2000 commented on pull request #3020: GOBBLIN-1175: Provide an option to all GobblinYarnAppLauncher to detach from Yarn application
Posted by GitBox <gi...@apache.org>.
sv2000 commented on pull request #3020:
URL: https://github.com/apache/incubator-gobblin/pull/3020#issuecomment-637176436
@ZihanLi58 @autumnust @abti Please review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-commenter edited a comment on pull request #3020: GOBBLIN-1175: Provide an option to all GobblinYarnAppLauncher to detach from Yarn application
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3020:
URL: https://github.com/apache/incubator-gobblin/pull/3020#issuecomment-637188284
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=h1) Report
> Merging [#3020](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/4325920dc72b82d2a96e2ba52ff0363d6f8575b4&el=desc) will **decrease** coverage by `0.19%`.
> The diff coverage is `12.00%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3020 +/- ##
============================================
- Coverage 45.71% 45.51% -0.20%
+ Complexity 9282 9254 -28
============================================
Files 1951 1951
Lines 74195 74592 +397
Branches 8208 8318 +110
============================================
+ Hits 33915 33949 +34
- Misses 37108 37467 +359
- Partials 3172 3176 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...gobblin/azkaban/AzkabanGobblinYarnAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tYXprYWJhbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9hemthYmFuL0F6a2FiYW5Hb2JibGluWWFybkFwcExhdW5jaGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...che/gobblin/yarn/GobblinYarnConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5Db25maWd1cmF0aW9uS2V5cy5qYXZh) | `66.66% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rg/apache/gobblin/yarn/GobblinYarnAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5BcHBMYXVuY2hlci5qYXZh) | `24.24% <21.42%> (+0.28%)` | `12.00 <0.00> (ø)` | |
| [.../apache/gobblin/service/modules/flowgraph/Dag.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93Z3JhcGgvRGFnLmphdmE=) | `60.46% <0.00%> (-33.88%)` | `29.00% <0.00%> (-9.00%)` | |
| [...service/modules/orchestration/DagManagerUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0RhZ01hbmFnZXJVdGlscy5qYXZh) | `55.07% <0.00%> (-29.99%)` | `22.00% <0.00%> (-17.00%)` | |
| [.../org/apache/gobblin/metrics/event/TimingEvent.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9ldmVudC9UaW1pbmdFdmVudC5qYXZh) | `48.61% <0.00%> (-21.39%)` | `7.00% <0.00%> (-8.00%)` | |
| [...blin/service/modules/orchestration/DagManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0RhZ01hbmFnZXIuamF2YQ==) | `56.16% <0.00%> (-15.08%)` | `13.00% <0.00%> (ø%)` | |
| [...in/service/modules/orchestration/Orchestrator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL09yY2hlc3RyYXRvci5qYXZh) | `38.93% <0.00%> (-10.78%)` | `13.00% <0.00%> (ø%)` | |
| [...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=) | `70.00% <0.00%> (-2.23%)` | `13.00% <0.00%> (ø%)` | |
| [.../service/monitoring/KafkaAvroJobStatusMonitor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9LYWZrYUF2cm9Kb2JTdGF0dXNNb25pdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| ... and [6 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=footer). Last update [4325920...15dbd33](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] asfgit closed pull request #3020: GOBBLIN-1175: Provide an option to all GobblinYarnAppLauncher to detach from Yarn application
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3020:
URL: https://github.com/apache/incubator-gobblin/pull/3020
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] sv2000 closed pull request #3020: GOBBLIN-1175: Provide an option to all GobblinYarnAppLauncher to detach from Yarn application
Posted by GitBox <gi...@apache.org>.
sv2000 closed pull request #3020:
URL: https://github.com/apache/incubator-gobblin/pull/3020
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-commenter edited a comment on pull request #3020: GOBBLIN-1175: Provide an option to all GobblinYarnAppLauncher to detach from Yarn application
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3020:
URL: https://github.com/apache/incubator-gobblin/pull/3020#issuecomment-637188284
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@72fc54f`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `12.50%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3020 +/- ##
=========================================
Coverage ? 45.71%
Complexity ? 9285
=========================================
Files ? 1951
Lines ? 74204
Branches ? 8207
=========================================
Hits ? 33921
Misses ? 37111
Partials ? 3172
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...gobblin/azkaban/AzkabanGobblinYarnAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tYXprYWJhbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9hemthYmFuL0F6a2FiYW5Hb2JibGluWWFybkFwcExhdW5jaGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...che/gobblin/yarn/GobblinYarnConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5Db25maWd1cmF0aW9uS2V5cy5qYXZh) | `66.66% <ø> (ø)` | `1.00 <0.00> (?)` | |
| [...rg/apache/gobblin/yarn/GobblinYarnAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5BcHBMYXVuY2hlci5qYXZh) | `24.24% <23.07%> (ø)` | `12.00 <0.00> (?)` | |
| [...n/java/org/apache/gobblin/util/ExecutorsUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvRXhlY3V0b3JzVXRpbHMuamF2YQ==) | `64.40% <0.00%> (ø)` | `16.00% <0.00%> (?%)` | |
| [...ig/store/zip/SimpleLocalIvyConfigStoreFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb25maWctbWFuYWdlbWVudC9nb2JibGluLWNvbmZpZy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbmZpZy9zdG9yZS96aXAvU2ltcGxlTG9jYWxJdnlDb25maWdTdG9yZUZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...va/org/apache/gobblin/publisher/DataPublisher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcHVibGlzaGVyL0RhdGFQdWJsaXNoZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...data/management/conversion/hive/task/HiveTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS90YXNrL0hpdmVUYXNrLmphdmE=) | `60.49% <0.00%> (ø)` | `7.00% <0.00%> (?%)` | |
| [...bblin/data/management/copy/OwnerAndPermission.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvT3duZXJBbmRQZXJtaXNzaW9uLmphdmE=) | `25.00% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
| [.../metrics/reporter/KeyValueEventObjectReporter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3MvcmVwb3J0ZXIvS2V5VmFsdWVFdmVudE9iamVjdFJlcG9ydGVyLmphdmE=) | `62.96% <0.00%> (ø)` | `5.00% <0.00%> (?%)` | |
| [.../apache/gobblin/runtime/NoopDatasetStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvTm9vcERhdGFzZXRTdGF0ZVN0b3JlLmphdmE=) | `47.36% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
| ... and [1944 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=footer). Last update [72fc54f...e5ae2b0](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-commenter edited a comment on pull request #3020: GOBBLIN-1175: Provide an option to all GobblinYarnAppLauncher to detach from Yarn application
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3020:
URL: https://github.com/apache/incubator-gobblin/pull/3020#issuecomment-637188284
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=h1) Report
> Merging [#3020](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/4325920dc72b82d2a96e2ba52ff0363d6f8575b4&el=desc) will **decrease** coverage by `4.24%`.
> The diff coverage is `11.53%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3020 +/- ##
============================================
- Coverage 45.71% 41.46% -4.25%
+ Complexity 9282 8464 -818
============================================
Files 1951 1951
Lines 74195 74241 +46
Branches 8208 8215 +7
============================================
- Hits 33915 30784 -3131
- Misses 37108 40537 +3429
+ Partials 3172 2920 -252
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...gobblin/azkaban/AzkabanGobblinYarnAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tYXprYWJhbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9hemthYmFuL0F6a2FiYW5Hb2JibGluWWFybkFwcExhdW5jaGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...che/gobblin/yarn/GobblinYarnConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5Db25maWd1cmF0aW9uS2V5cy5qYXZh) | `66.66% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rg/apache/gobblin/yarn/GobblinYarnAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5BcHBMYXVuY2hlci5qYXZh) | `24.14% <20.00%> (+0.18%)` | `12.00 <0.00> (ø)` | |
| [.../org/apache/gobblin/util/filters/HiddenFilter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsdGVycy9IaWRkZW5GaWx0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...g/apache/gobblin/cluster/HelixMessageSubTypes.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhNZXNzYWdlU3ViVHlwZXMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...gobblin/runtime/mapreduce/GobblinOutputFormat.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWFwcmVkdWNlL0dvYmJsaW5PdXRwdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../gobblin/compaction/suite/CompactionSuiteBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vc3VpdGUvQ29tcGFjdGlvblN1aXRlQmFzZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-10.00%)` | |
| [...obblin/compaction/source/CompactionFailedTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vc291cmNlL0NvbXBhY3Rpb25GYWlsZWRUYXNrLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...n/cluster/event/ClusterManagerShutdownRequest.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvZXZlbnQvQ2x1c3Rlck1hbmFnZXJTaHV0ZG93blJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...blin/compaction/mapreduce/RecordKeyMapperBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL1JlY29yZEtleU1hcHBlckJhc2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [160 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3020/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=footer). Last update [4325920...5805b48](https://codecov.io/gh/apache/incubator-gobblin/pull/3020?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] sv2000 closed pull request #3020: GOBBLIN-1175: Provide an option to all GobblinYarnAppLauncher to detach from Yarn application
Posted by GitBox <gi...@apache.org>.
sv2000 closed pull request #3020:
URL: https://github.com/apache/incubator-gobblin/pull/3020
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org