You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/12/14 09:59:37 UTC

[GitHub] [geode-native] albertogpz commented on a change in pull request #697: Feature/asio

albertogpz commented on a change in pull request #697:
URL: https://github.com/apache/geode-native/pull/697#discussion_r542255213



##########
File path: cppcache/src/Connector.hpp
##########
@@ -37,24 +37,28 @@ constexpr std::chrono::milliseconds DEFAULT_READ_TIMEOUT = DEFAULT_TIMEOUT;
 
 constexpr std::chrono::milliseconds DEFAULT_WRITE_TIMEOUT = DEFAULT_TIMEOUT;
 
-class Connector {
+class APACHE_GEODE_EXPORT Connector {

Review comment:
       This was already there in the version of the branch I took as base. I have removed the export as I do not see the need.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org