[GitHub] [lucene] mocobeta edited a comment on pull request #638: LUCENE-10393: Unify resource loader in kuromoji and nori

[GitBox <gi...@apache.org>]

mocobeta edited a comment on pull request #638:
URL: https://github.com/apache/lucene/pull/638#issuecomment-1028598383


   I opened `o.a.l.a.ja.dict` and `o.a.l.a.ko.dict` to `analysis-common` module to allow `DictionaryResourceLoader` (common utility) to read dictionary resources in kuromoji and nori module.
   
   Then `TestModuleLayer.testAllOpenAnalysisPackagesInSync()` says
   ```
   error: [Opens should only be targeted to Lucene Core.] 
   ```
   
   Is there a way to loosen this restriction? I don't think the resource loader should resident in lucene-core, it's too specific to kuromoji and nori (and a bit hacky; I think the two-args constructor should be break down into two constructors at the next major release - one for resources on the classpath and another for ones on the file path. In the future, I hope we will be able to resolve LUCENE-8816 then we'll need only one constructor that loads the dictionary resources from classpaths).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org