You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/10/18 05:37:50 UTC

[GitHub] rhtyd edited a comment on issue #2901: params: allow signatureversion and expires without logging

rhtyd edited a comment on issue #2901: params: allow signatureversion and expires without logging
URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-430881076
 
 
   @pyr this is not acceptable, you merged a commit on master directly without the PR id and without any testing results on them. Your change may therefore potentially break master for others. Instead of closing or pushing the change, you should have reopened this PR or create a new PR and wait for test results, even though we requested you to re-open your PR. If things were not clear you could discuss and/or ask questions but you committed the change on master. Also now the PR status is `closed` and not `merged` this will cause search/audit issues in future.
   You may see how other PRs get reviewed, tested and (squash) merged.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services